GNOME Bugzilla – Bug 765441
There is no alloca.h on FreeBSD
Last modified: 2016-04-23 02:53:04 UTC
The recently added egg-simple-label.c uses alloca.h. It may be possible to fix it by replacing it with stdlib.h, but I think using the standard VLA feature is better.
Created attachment 326575 [details] [review]
egg-simple-label: replace alloca with C99 VLA
alloca is a non-standard feature. As we already requires a compiler
supporting C11, using the standard variable-length array seems to be
better. Although VLA is an optional feature in C11, both gcc and clang
support it for a long time.
This commit fixes the build on FreeBSD, which puts alloca in stdlib.h
instead of alloca.h.
Review of attachment 326575 [details] [review]:
LGTM, good to know about the alloca situation
Attachment 326575 [details] pushed as 9568071 - egg-simple-label: replace alloca with C99 VLA