After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765436 - Don't build multiple cerbero checkouts into the same path
Don't build multiple cerbero checkouts into the same path
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
unspecified
Other Linux
: Normal enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-22 17:54 UTC by Xavier Claessens
Modified: 2016-04-25 12:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Change default home_dir to top_srcdir/build/ (2.52 KB, patch)
2016-04-22 17:55 UTC, Xavier Claessens
committed Details | Review

Description Xavier Claessens 2016-04-22 17:54:53 UTC
Currently if I have many cerbero checkouts, for example one for 1.8, one for master, some for specific projects, by default they will all mess up into ~/cerbero.
Comment 1 Xavier Claessens 2016-04-22 17:55:17 UTC
Created attachment 326566 [details] [review]
Change default home_dir to top_srcdir/build/

It has the advantage of having self-contained cerbero trees which
is easier to maintain when having multiple cerbero checkouts. Using
~/cerbero make it too easy to mess up different builds into the same
destination.

Note that build/ directory is already in .gitignore.
Comment 2 Xavier Claessens 2016-04-22 19:49:39 UTC
It's also really useful with that:
  git worktree add ../cerbero-1.8 origin/1.8
Comment 3 Sebastian Dröge (slomo) 2016-04-23 07:01:30 UTC
Comment on attachment 326566 [details] [review]
Change default home_dir to top_srcdir/build/

Makes sense to me and bothered me many times too, but I think it was like that some time ago and then was changed by Edward? Related to jenkins? Or I confuse that with something else.
Comment 4 Tim-Philipp Müller 2016-04-23 09:46:17 UTC
Should wait for input from Edward before changing it.
Comment 5 Sebastian Dröge (slomo) 2016-04-23 10:42:57 UTC
Oh I forgot to mention that I checked with git blame, and my memory seems to be wrong. It always seemed to be like that... but there was *something* that Edward changed, I just can't find it.
Comment 6 Olivier Crête 2016-04-23 10:46:24 UTC
The jenkins build changes the config to set a custom home_dir already I think.
Comment 7 Edward Hervey 2016-04-25 07:19:51 UTC
Regarding jenkins, we do indeed set a custom home_dir in the configuration file used to build. The commit shouldn't cause any issues afaics
Comment 8 Sebastian Dröge (slomo) 2016-04-25 07:21:37 UTC
Then let's go ahead with this :)
Comment 9 Tim-Philipp Müller 2016-04-25 12:38:34 UTC
Pushed to master:

commit a31b5b7f4cfe9b2d49f5b538701d398981f82a73
Author: Xavier Claessens <xavier.claessens@collabora.com>
Date:   Fri Apr 22 13:33:22 2016 -0400

    Change default home_dir to $top_srcdir/build/
    
    This has the advantage of having self-contained cerbero trees which
    is easier to maintain when using multiple cerbero checkouts. Using
    ~/cerbero make it too easy to mess up different builds into the same
    destination.
    
    Note that build/ directory is already in .gitignore.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=765436