Created attachment 326555 [details] [review]
aggregator: Check all pads for data when live

When live, we still need to inspect all pads queue in order to determin
if we have received the first buffer or not.

Review of attachment 326555 [details] [review]:

Looks good to me, but

::: gst-libs/gst/base/gstaggregator.c
@@ -449,1 @@
-    if (gst_aggregator_pad_queue_is_empty (pad) && !pad->priv->eos) {

Why did you remove the code that deals with EOS ? If EOS has been received, the pad should not be counted as empty.

Oops, was not intentional.

Created attachment 326574 [details] [review]
aggregator: Check all pads for data when live

When live, we still need to inspect all pads queue in order to determin
if we have received the first buffer or not.

Review of attachment 326574 [details] [review]:

::: gst-libs/gst/base/gstaggregator.c
@@ +441,3 @@
 
+    /* Pad at EOS are considered having data, but not as first buffer */
+    if (!pad->priv->eos) {

Actually I'm uncertain that this is correct. I believe we could queue both data and EOS, and we'd missed the first buffer ...

Created attachment 326577 [details] [review]
aggregator: Check all pads for data when live

When live, we still need to inspect all pads queue in order to determin
if we have received the first buffer or not.

Review of attachment 326577 [details] [review]:

Makes sense

Comment on attachment 326577 [details] [review]
aggregator: Check all pads for data when live

commit 38895f236478ca5c0966d7d5b56897594b3caaaa
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Fri Apr 22 10:15:39 2016 -0400

    aggregator: Check all pads for data when live
    
    When live, we still need to inspect all pads queue in order to determin
    if we have received the first buffer or not.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=765431