After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765397 - Add gst_map_info_unmap method
Add gst_map_info_unmap method
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-21 21:30 UTC by Marcin Kolny (IRC: loganek)
Modified: 2016-04-22 07:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-mapinfo-add-unmap-method.patch (2.12 KB, patch)
2016-04-21 21:30 UTC, Marcin Kolny (IRC: loganek) 		reviewed Details | Review

Description Marcin Kolny (IRC: loganek) 2016-04-21 21:30:20 UTC 
Created attachment 326523 [details] [review]
0001-mapinfo-add-unmap-method.patch

I've just noted, that gst_buffer_unmap() method doesn't require GstBuffer object. So I'm suggesting to extend the API by gst_map_info_unmap() method.
On API break, gst_buffer_unmap() could be removed.
Comment 1 Tim-Philipp Müller 2016-04-21 22:18:18 UTC 
Thanks for the suggestion and the patch.

I'm not sure this is a good idea though. I think map()/unmap() should be symmetrical and think the added benefit of this new function is minor.
Comment 2 Marcin Kolny (IRC: loganek) 2016-04-22 06:50:48 UTC 
OK, Thanks.
So I think the bug can be closed then.