GNOME Bugzilla – Bug 765394
Unset MAKEFLAGS to avoid build errors
Last modified: 2016-04-23 10:23:43 UTC
I have MAKEFLAGS=-j4 set in my .bashrc which cause issues with recipes that does not support parallel builds like libtheora for windows. I think build env should unset it to avoid user settings messing up with cerbero builds.
Created attachment 326520 [details] [review] Unset MAKEFLAGS env variable when building makefile recipes This avoids having user settings messing up our build.
On Windows, parallel builds don't work well in general. Also this patch is breaking my use case, I have MAKEFLAGS=-j16 in the environment when using cerbero :) But I guess I could use the parallel build feature of cerbero instead. That said, this patch makes sense as it gives cerbero the control over this setting.
+1 from me obviously ;) I think cerbero as a build system should be as much a controlled environment as possible.
(In reply to Sebastian Dröge (slomo) from comment #2) > On Windows, parallel builds don't work well in general. I made several builds lately, only libtheora failed to build with MAKEFLAGS=-j4. If other recipes are known to be problematic on windows, can parallel build be disabled on a per-platform basis? > Also this patch is breaking my use case, I have MAKEFLAGS=-j16 in the > environment when using cerbero :) But I guess I could use the parallel build > feature of cerbero instead. I was doing exactly the same, I just added allow_parallel_build = True in my .cerbero/cerbero.cbc for the same result. > That said, this patch makes sense as it gives cerbero the control over this > setting. Yes I think it's important, user flags could lead to hard to find issues.
commit a5d6bb96cc364606905a5f65ba88fbcbed813622 Author: Xavier Claessens <xavier.claessens@collabora.com> Date: Thu Apr 21 16:16:37 2016 -0400 Unset MAKEFLAGS env variable when building makefile recipes This avoids having user settings messing up our build. https://bugzilla.gnome.org/show_bug.cgi?id=765394