After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765387 - [review] cleanup dns and rc-manager settings and add new rc-manager=unmanaged [th/dns-rc-manager-bgo765387]
[review] cleanup dns and rc-manager settings and add new rc-manager=unmanaged...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-04-21 16:48 UTC by Thomas Haller
Modified: 2016-08-29 17:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2016-04-21 16:48:56 UTC 
please review
Comment 1 Beniamino Galvani 2016-04-26 11:33:36 UTC 
> dns: rename "rc-manager=none" to "symlink"

- * @NM_DNS_MANAGER_RESOLV_CONF_MAN_NONE: NM writes resolv.conf
+ * @NM_DNS_MANAGER_RESOLV_CONF_MAN_SYMLINK: NM writes resolv.conf
  *   by symlinking it to the run state directory.
  * @NM_DNS_MANAGER_RESOLV_CONF_MAN_FILE: Like NONE, but instead of symlinking

"Like SYMLINK".

The rest looks good to me; I don't find the new "rc-manager=unmanaged"
option particularly useful, but if you say that there are valid use
cases for it, that's fine with me.
Comment 2 Thomas Haller 2016-04-26 12:01:07 UTC 
(In reply to Beniamino Galvani from comment #1)
> > dns: rename "rc-manager=none" to "symlink"
> 
> - * @NM_DNS_MANAGER_RESOLV_CONF_MAN_NONE: NM writes resolv.conf
> + * @NM_DNS_MANAGER_RESOLV_CONF_MAN_SYMLINK: NM writes resolv.conf
>   *   by symlinking it to the run state directory.
>   * @NM_DNS_MANAGER_RESOLV_CONF_MAN_FILE: Like NONE, but instead of
> symlinking
> 
> "Like SYMLINK".

Fixed.

> The rest looks good to me; I don't find the new "rc-manager=unmanaged"
> option particularly useful, but if you say that there are valid use
> cases for it, that's fine with me.

I think it's more for completeness and adding it is 5 lines of code.
It only makes sense when using a plugin (dns != none,default), but when not wanting NM to touch /etc/resolv.conf.


Thank you.