GNOME Bugzilla – Bug 765384
Seal GdaBlobOp: Remove public members in class definition
Last modified: 2018-09-21 13:51:20 UTC
GdaBlobOp has a class definition as: struct _GdaBlobOpClass { GObjectClass parent_class; gpointer functions; /*< private >*/ /* Padding for future expansion */ void (*_gda_reserved1) (void); void (*_gda_reserved2) (void); void (*_gda_reserved3) (void); void (*_gda_reserved4) (void); }; This makes use functions as a pointer to GdaBlobOpFunctions, which I think, should be virtual methods directly on GdaBlobOpClass. and a object definition as: struct _GdaBlobOp { GObject object; GdaBlobOpPrivate *priv; /* Padding for future expansion */ gpointer _gda_reserved1; }; Should we use g_type_add_class_private() and G_TYPE_CLASS_GET_PRIVATE() to install private data? For gda_reserved1, I think we need not install class members, but private ones, using getters/setters, as a convention. Pending for comments in order to continue this changes.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/libgda/issues/89.