After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765384 - Seal GdaBlobOp: Remove public members in class definition
Seal GdaBlobOp: Remove public members in class definition
Status: RESOLVED OBSOLETE
Product: libgda
Classification: Other
Component: Vala bindings
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Daniel Espinosa
gnome-db Maintainers
Depends on:
Blocks: 754725
 
 
Reported: 2016-04-21 16:14 UTC by Daniel Espinosa
Modified: 2018-09-21 13:51 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Daniel Espinosa 2016-04-21 16:14:14 UTC
GdaBlobOp has a class definition as:


struct _GdaBlobOpClass {
	GObjectClass parent_class;
	gpointer     functions;

	/*< private >*/
	/* Padding for future expansion */
	void (*_gda_reserved1) (void);
	void (*_gda_reserved2) (void);
	void (*_gda_reserved3) (void);
	void (*_gda_reserved4) (void);
};

This makes use functions as a pointer to GdaBlobOpFunctions, which I think, should be virtual methods directly on GdaBlobOpClass.




and a object definition as:

struct _GdaBlobOp {
	GObject object;
	GdaBlobOpPrivate *priv;

	/* Padding for future expansion */
	gpointer _gda_reserved1;
};


Should we use g_type_add_class_private() and G_TYPE_CLASS_GET_PRIVATE() to install private data?

For gda_reserved1, I think we need not install class members, but private ones, using getters/setters, as a convention.

Pending for comments in order to continue this changes.
Comment 1 GNOME Infrastructure Team 2018-09-21 13:51:20 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/libgda/issues/89.