GNOME Bugzilla – Bug 765370
Can't set event's time when time format is "AM / PM"
Last modified: 2017-04-17 18:20:40 UTC
When Gnome's time format is setted "AM / PM", (This means /org/gnome/desktop/interface/clock-format is setted as '12h') (System Setting -> Date & Time -> Time Format : "AM / PM") I'm not able to set event's time after 11:59 AM ,in Gnome Calendar. - There is no selector for "AM / PM" in time picker. - I cannot set time in 24h, as hour spin button only accepts between 0 ~ 11. Workaround: Set Gnome's time format as "24-hour". After then, hour spin button accepts 0 ~ 23, and event's time can be set PM.
This is also true for me.
Same problem on Manjaro (based on archlinux) with gnome-calendar 3.20.1-1.
Created attachment 327509 [details] Screenshot - no AM/PM selection
*** Bug 766634 has been marked as a duplicate of this bug. ***
This is a regression. I was able to change this in an older version (probably 3.18) with an AM/PM box. This should be changed to confirmed.
Seems there are a a handful of features missing from GNOME 3.20, I swear it got dumbed down this release. I have this problem too with Fedora 24, GNOME 3.20.2
Created attachment 332238 [details] [review] edit-dialog: set time format unconditionally If GcalEditDialog.format_24h is initialized to zero, the call to gcal_edit_dialog_set_time_format() from GcalWindow will not make period_combo boxes visible on systems, where 12-hour clocks are used. This commit fixes that by removing the if statement from the function.
Created attachment 332239 [details] [review] time-selector: fix AM to PM time logic Currently, the hour component of the time is doubled when switching from AM to PM, which is incorrect. This commit fixes the logic by adding 12 hours when switching to PM.
The second patch is for a bug I found whilst fixing the reported one. I did not file a report or check if there is one already. Apologies in advance. :)
Review of attachment 332238 [details] [review]: Sure.
Review of attachment 332239 [details] [review]: Nice touch, thanks.
Thanks for your fixes! Attachment 332238 [details] pushed as dd4142f - edit-dialog: set time format unconditionally Attachment 332239 [details] pushed as d0143db - time-selector: fix AM to PM time logic
Is this change in 3.21.4?
(In reply to Alexander from comment #13) > Is this change in 3.21.4? No.