After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765353 - unzip program can't be configured
unzip program can't be configured
Status: RESOLVED FIXED
Product: gucharmap
Classification: Core
Component: general
8.0.x
Other Linux
: Normal normal
: ---
Assigned To: gucharmap maintainers
gucharmap maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-21 00:34 UTC by Michael Biebl
Modified: 2016-04-24 11:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Michael Biebl 2016-04-21 00:34:04 UTC 
configure.ac contains:

# uses the UNZIP env var and interprets it as its options.
AC_ARG_VAR([PROG_UNZIP],[the unzip programme])

I assume the intention here is to let the user specify the unzip program path.

The next line though contains

AC_PATH_PROG([PROG_UNZIP],[unzip],[false])

This means, PROG_UNZIP will be overridden with /usr/bin/unzip (or wherever unzip is found).

In Debian the unicode files are bzip2, so I tried to use "PROG_UNZIP=bunzip2 ./configure", but this didsn't work as AC_PATH_PROG did overwrite this.

(the same problem applies to WGET and SHA512SUM)
Comment 1 Michael Biebl 2016-04-21 00:41:26 UTC 
config.log contains:

$ ./configure PROG_UNZIP=bunzip2
...
ac_cv_env_PROG_UNZIP_set=set
ac_cv_env_PROG_UNZIP_value=bunzip2
...
ac_cv_path_PROG_UNZIP=/usr/bin/unzip
...
PROG_UNZIP='/usr/bin/unzip'
Comment 2 Michael Biebl 2016-04-21 02:14:01 UTC 
May I suggest something like that:

diff --git a/configure.ac b/configure.ac
index 4ca2acf..45b17b4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -188,7 +188,7 @@ AC_SUBST([unicodedatadir])
 # Note! Not using UNZIP as variable name here since unzip itself
 # uses the UNZIP env var and interprets it as its options.
 AC_ARG_VAR([PROG_UNZIP],[the unzip programme])
-AC_PATH_PROG([PROG_UNZIP],[unzip],[false])
+AC_PATH_PROGS([PROG_UNZIP],[$PROG_UNZIP unzip],[false])
Comment 3 Christian Persch 2016-04-24 11:04:29 UTC 
Fixed on master.

I'd love to have this work out-of-the-box on debian; any chance you could upstream an improved debian patch by making it work with debian as well as upstream unicode data? :-)