After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765343 - Use GtkMenuButton in the overview searchbar
Use GtkMenuButton in the overview searchbar
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-04-20 19:11 UTC by Alessandro Bono
Modified: 2016-04-23 06:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use pan-down-symbolic, not go-down-symbolic, in OverviewSearchbar (1.14 KB, patch)
2016-04-20 19:12 UTC, Alessandro Bono 		committed Details | Review
searchbar: Remove 'raised' style class (982 bytes, patch)
2016-04-20 19:12 UTC, Alessandro Bono 		committed Details | Review
searchbar: Use GtkMenuButton in OverviewSearchbar (2.23 KB, patch)
2016-04-20 19:13 UTC, Alessandro Bono 		committed Details | Review

Description Alessandro Bono 2016-04-20 19:11:38 UTC 
instead of emulate it.
Comment 1 Alessandro Bono 2016-04-20 19:12:22 UTC 
Created attachment 326445 [details] [review]
Use pan-down-symbolic, not go-down-symbolic, in OverviewSearchbar

... because it opens a dropdown menu. The other one is for jumping to
the next occurrence in a search.

Original patch from Debarshi Ray for gnome-photos.
Comment 2 Alessandro Bono 2016-04-20 19:12:45 UTC 
Created attachment 326446 [details] [review]
searchbar: Remove 'raised' style class

It is a NOP in current Adwaita.
Comment 3 Alessandro Bono 2016-04-20 19:13:12 UTC 
Created attachment 326447 [details] [review]
searchbar: Use GtkMenuButton in OverviewSearchbar
Comment 4 Cosimo Cecchi 2016-04-21 09:26:24 UTC 
Review of attachment 326445 [details] [review]:

Looks good
Comment 5 Cosimo Cecchi 2016-04-21 09:26:43 UTC 
Review of attachment 326446 [details] [review]:

OK
Comment 6 Cosimo Cecchi 2016-04-21 09:27:45 UTC 
Review of attachment 326447 [details] [review]:

You could squash the other patches into this
Comment 7 Cosimo Cecchi 2016-04-23 04:20:21 UTC 
[replying to a comment I saw from IRC]

I was thinking that the value of keeping the history in this case wasn't much, as we remove the custom widget altogether. But it doesn't hurt to keep it either, so please push all the patches if that's what you prefer :)
Comment 8 Alessandro Bono 2016-04-23 06:50:02 UTC 
Attachment 326445 [details] pushed as 3a02ac5 - Use pan-down-symbolic, not go-down-symbolic, in OverviewSearchbar
Attachment 326446 [details] pushed as 7b991ae - searchbar: Remove 'raised' style class
Attachment 326447 [details] pushed as 28ccbf6 - searchbar: Use GtkMenuButton in OverviewSearchbar