After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765340 - Use GtkMenuButton in the overview searchbar
Use GtkMenuButton in the overview searchbar
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-04-20 19:02 UTC by Alessandro Bono
Modified: 2016-06-27 09:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
overview-searchbar: Remove 'raised' style class (1.17 KB, patch)
2016-04-20 19:03 UTC, Alessandro Bono 		committed Details | Review
overview-searchbar: Use GtkMenuButton (4.52 KB, patch)
2016-04-20 19:03 UTC, Alessandro Bono 		committed Details | Review

Description Alessandro Bono 2016-04-20 19:02:59 UTC 
instead of emulate it.
Comment 1 Alessandro Bono 2016-04-20 19:03:30 UTC 
Created attachment 326441 [details] [review]
overview-searchbar: Remove 'raised' style class

It is a NOP in current Adwaita.
Comment 2 Alessandro Bono 2016-04-20 19:03:50 UTC 
Created attachment 326442 [details] [review]
overview-searchbar: Use GtkMenuButton
Comment 3 Debarshi Ray 2016-06-27 07:22:06 UTC 
Review of attachment 326441 [details] [review]:

Looks good to me.
Comment 4 Debarshi Ray 2016-06-27 07:36:49 UTC 
Review of attachment 326442 [details] [review]:

Thanks for the nice patch, Alessandro!
Comment 5 Alessandro Bono 2016-06-27 09:54:26 UTC 
Attachment 326441 [details] pushed as 349ef8b - overview-searchbar: Remove 'raised' style class
Attachment 326442 [details] pushed as 06c990a - overview-searchbar: Use GtkMenuButton