GNOME Bugzilla – Bug 765328
VteTerminalPrivate::search_find always returns false
Last modified: 2016-08-01 22:40:17 UTC
Created attachment 326425 [details] [review] fixes vte_terminal_search_find always returning false It seems that the culprit commit is this one 72b1185d2e1b0c5b5b481fb9f8ca7701dbc5d4da which switched the default return state (but not all true cases will correctly update match_state to `true` ). Switching the default back to true should fix this.
Comment on attachment 326425 [details] [review] fixes vte_terminal_search_find always returning false Thanks! Ok to commit to master and cherry-pick -x to 0-44.
Pushed to master and 0-44, thanks! For future reference, please use your full name in the git Author field.
I noticed that in fedora 24 with [root@mother rave]# rpm -qa vte291 vte291-0.44.2-1.fc24.x86_64 reverse search is broken with gnome-terminal and mate-terminal. Same mate-terminal version works well in fedora 23 with vte291-0.42.x Do we have a regression here?
This has nothing to do with reverse search. Quite possible it's a regression in vte; lease open a new bug for this, and if you can, try to bisect vte to find the commit responsible.
done https://bugzilla.gnome.org/show_bug.cgi?id=769400