After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765322 - [Patch] Remove unnecessary redirects in every request to weather.noaa.gov
[Patch] Remove unnecessary redirects in every request to weather.noaa.gov
Status: RESOLVED FIXED
Product: libgweather
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: future
Assigned To: libgweather-maint
libgweather-maint
Depends on:
Blocks:
 
 
Reported: 2016-04-20 12:24 UTC by Daniel Aleksandersen
Modified: 2016-05-29 18:57 UTC
See Also:
GNOME target: ---
GNOME version: 3.19/3.20


Attachments
0001-Avoid-redirects-from-US-Weather-Service.patch (791 bytes, patch)
2016-04-20 12:24 UTC, Daniel Aleksandersen
committed Details | Review

Description Daniel Aleksandersen 2016-04-20 12:24:50 UTC
Created attachment 326407 [details] [review]
0001-Avoid-redirects-from-US-Weather-Service.patch

Every request to “http://weather.noaa.gov/cgi-bin/mgetmetar.pl” is permanently redirected to “http://weather.noaa.gov/mgetmetar.php”. This patch removes the unnecessary round-trip back and forth with the server to get the new data location.
Comment 1 Giovanni Campagna 2016-04-20 18:51:28 UTC
Review of attachment 326407 [details] [review]:

Sure!
Comment 2 Daniel Aleksandersen 2016-04-21 14:23:07 UTC
I haven’t got commit access, so someone will have to commit it for me. ☺
Comment 3 Daniel Aleksandersen 2016-05-29 18:48:38 UTC
Ping. Still need someone with commit access to actually commit this.
Comment 4 Giovanni Campagna 2016-05-29 18:57:13 UTC
Argh sorry I thought I had committed this, but apparently I forgot.