After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765315 - player: Add A/V offset property
player: Add A/V offset property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other Linux
: Normal enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-20 11:00 UTC by Sebastian Dröge (slomo)
Modified: 2016-04-28 10:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for audio-video-offset in GstPlayer element (5.38 KB, patch)
2016-04-28 03:55 UTC, barunsingh 		needs-work Details | Review
Rebased. (5.37 KB, patch)
2016-04-28 09:54 UTC, barunsingh 		committed Details | Review

Description Sebastian Dröge (slomo) 2016-04-20 11:00:32 UTC 
See https://github.com/sdroege/gst-player/issues/98
Comment 1 barunsingh 2016-04-22 04:45:13 UTC 
I think this is just like "av-offset" property in playbin. If so,
I would like to add one property as well as getter/setter functions.
Please suggest further.
Comment 2 barunsingh 2016-04-22 05:11:38 UTC 
I think this is just like "av-offset" property in playbin. If so,
I would like to add one property as well as getter/setter functions.
Please suggest further.
Comment 3 Sebastian Dröge (slomo) 2016-04-22 07:05:20 UTC 
Yes, maybe with a more meaningful name like audio-video-offset :)
Comment 4 barunsingh 2016-04-22 07:28:54 UTC 
(In reply to Sebastian Dröge (slomo) from comment #3)
> Yes, maybe with a more meaningful name like audio-video-offset :)

Ok. Patch is ready and sent for verification. will upload by today evening or on monday. :)
Comment 5 barunsingh 2016-04-28 03:55:27 UTC 
Created attachment 326909 [details] [review]
patch for audio-video-offset in GstPlayer element
Comment 6 Sebastian Dröge (slomo) 2016-04-28 06:33:41 UTC 
Review of attachment 326909 [details] [review]:

Looks good, thanks!
Comment 7 Sebastian Dröge (slomo) 2016-04-28 08:59:43 UTC 
Comment on attachment 326909 [details] [review]
patch for audio-video-offset in GstPlayer element

The patch does not apply to latest GIT master. Can you rebase it?
Comment 8 barunsingh 2016-04-28 09:01:52 UTC 
Sure. give me couple of minutes.
Comment 9 barunsingh 2016-04-28 09:54:15 UTC 
Created attachment 326928 [details] [review]
Rebased.
Comment 10 Sebastian Dröge (slomo) 2016-04-28 10:19:20 UTC 
commit bf43460018eceb5942e7f0a135bc86f212b9f638
Author: Barun Kumar Singh <barun.singh@samsung.com>
Date:   Thu Apr 28 15:19:17 2016 +0530

    player: Add audio-video-offset property and setter/getter API
    
    https://bugzilla.gnome.org/show_bug.cgi?id=765315