After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765301 - cp437.py: Python 3 compatibility
cp437.py: Python 3 compatibility
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-20 09:21 UTC by Jan Beran
Modified: 2016-04-20 17:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Jan Beran 2016-04-20 09:21:59 UTC 
src/cp437.py does not work in Python 3. My pull request

https://github.com/GNOME/vte/pull/6

solves the problem to work in both Python 2 and Python 3 versions. May I ask for a review?
Comment 1 Egmont Koblinger 2016-04-20 10:10:23 UTC 
Do we need this script at all?

The source tree (build rules, etc.) doesn't seem to refer to it in any way.

It also prints escape sequences that are not supported by VTE:

"\e(U": see http://invisible-island.net/xterm/ctlseqs/ctlseqs.html -> "ESC ( C   Designate G0 Character Set" -> nothing for "U" here.

"\e*B" and "\e+B": These are "Designate G2/G3 Character Set" whereas VTE only supports G0 and G1.
Comment 2 Egmont Koblinger 2016-04-20 10:16:47 UTC 
Seems to me that this file should have been dropped in commit fca0c15 (or, in turn, commit 02da653).
Comment 3 Jan Beran 2016-04-20 14:17:21 UTC 
I can see now, that src/cp437.py is not included the distribution even it survives at the git repository.
Comment 4 Christian Persch 2016-04-20 16:23:51 UTC 
Let's git rm it.

Also for future reference, please attach patches in git am'able form, instead of pointing to nonfree web services.
Comment 5 Egmont Koblinger 2016-04-20 17:27:41 UTC 
git rm'ed.