After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765255 - Instruction list is not printing correctly with dark theme
Instruction list is not printing correctly with dark theme
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2016-04-19 12:12 UTC by Nayan Deshmukh
Modified: 2016-06-09 19:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Change color of instructionWidget before printing (1.14 KB, patch)
2016-04-19 13:44 UTC, Nayan Deshmukh 		none Details | Review
printLayout: Change color of instructionWidget before printing (1.15 KB, patch)
2016-06-09 06:47 UTC, Nayan Deshmukh 		accepted-commit_now Details | Review

Description Nayan Deshmukh 2016-04-19 12:12:42 UTC 
There's a bug with dark theme and the printed text. When printing in dark theme the route text matches the system's dark theme and makes it unreadable. I tested this on Fedora 24 Alpha 7 as of today
[reply] [−] Comment 114
Comment 1 Nayan Deshmukh 2016-04-19 13:44:00 UTC 
Created attachment 326323 [details] [review]
Change color of instructionWidget before printing

Set font color of intructionWidget to black manually to avoid
printing in lighter font colors according to the theme
Comment 2 Marcus Lundblad 2016-06-09 06:23:29 UTC 
Review of attachment 326323 [details] [review]:

::: src/printLayout.js
@@ +213,3 @@
 
+        instructionWidget.get_style_context().add_class('printing-text');
+

Minor nitpick, maybe the extra blank line should be removed?
Comment 3 Marcus Lundblad 2016-06-09 06:37:31 UTC 
Review of attachment 326323 [details] [review]:

I think the first line of the commit message should contain the module name,
something like:

printLayout: Change color of instructionWidget

...
Comment 4 Nayan Deshmukh 2016-06-09 06:47:57 UTC 
Created attachment 329430 [details] [review]
printLayout: Change color of instructionWidget before printing

Set font color of intructionWidget to black manually to avoid
printing in lighter font colors according to the theme
Comment 5 Marcus Lundblad 2016-06-09 19:36:22 UTC 
I tested the patch, works great!
Thanks!
Comment 6 Marcus Lundblad 2016-06-09 19:37:34 UTC 
Review of attachment 329430 [details] [review]:

LGTM