After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765245 - Visual Studio builds: Enable introspection builds
Visual Studio builds: Enable introspection builds
Status: RESOLVED FIXED
Product: librsvg
Classification: Core
Component: general
unspecified
Other Windows
: Normal normal
: ---
Assigned To: librsvg maintainers
librsvg maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-19 06:57 UTC by Fan, Chun-wei
Modified: 2016-04-20 08:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Add common autotools module to generate items for building introspection under Visual Studio (7.46 KB, patch)
2016-04-20 05:49 UTC, Fan, Chun-wei 		committed Details | Review
Visual Studio builds: Support building introspection (9.75 KB, patch)
2016-04-20 05:52 UTC, Fan, Chun-wei 		committed Details | Review

Description Fan, Chun-wei 2016-04-19 06:57:32 UTC 
Hi,

librsvg has recently added support for building under Visual Studio, without the means to build the introspection files for it.  As the state of running and building G-I is much improved on Visual Studio, this patch will attempt to add such support.

With blessings, thank you!
Comment 1 Fan, Chun-wei 2016-04-20 05:49:24 UTC 
Created attachment 326370 [details] [review]
build: Add common autotools module to generate items for building introspection under Visual Studio

Hi,

This adds an autotools module, which is copied from gobject-introspection and is used in the GTK+ stack, which can be included $(srcroot)/Makefile.am to generate the list of files to introspect, as well as the command lines to g-ir-scanner and g-ir-compiler to build the introspection files.
Comment 2 Fan, Chun-wei 2016-04-20 05:52:06 UTC 
Created attachment 326371 [details] [review]
Visual Studio builds: Support building introspection

Hi,

This adds a set of NMake Makefiles and updates $(srcroot)/Makefile.am to use the autotools module in the previous patch so that the items needed for building introspection on Visual Studio builds will be available upon 'make dist'.

With blessings, thank you!
Comment 3 Paolo Borelli 2016-04-20 06:59:15 UTC 
Review of attachment 326370 [details] [review]:

sure, go ahead
Comment 4 Paolo Borelli 2016-04-20 06:59:24 UTC 
Review of attachment 326371 [details] [review]:

looks good
Comment 5 Fan, Chun-wei 2016-04-20 08:09:24 UTC 
Hi Paolo,

Thanks for the fast review, I have pushed the patches as:
-326370: 09d7427
-326371: 42a58e9

With blessings, thank you!