After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765221 - Pressing the delete key while editing the Notes column of an account attempts to delete the account
Pressing the delete key while editing the Notes column of an account attempts...
Status: RESOLVED DUPLICATE of bug 616709
Product: GnuCash
Classification: Other
Component: User Interface General
unspecified
Other Windows
: Normal normal
: ---
Assigned To: gnucash-ui-maint
gnucash-ui-maint
Depends on:
Blocks:
 
 
Reported: 2016-04-18 15:25 UTC by manekineko
Modified: 2018-06-29 23:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Change short cut key on Accounts page. (1.24 KB, patch)
2016-09-14 11:09 UTC, Bob
rejected Details | Review

Description manekineko 2016-04-18 15:25:55 UTC
If you have the Notes column on the Accounts page enabled, and you are typing edits into an account's notes, if you press the delete key, GnuCash attempts to delete the account, instead of deleting the character to the immediate right of the cursor.

Backspace works normally as expected, however.
Comment 1 Bob 2016-09-14 11:09:48 UTC
Created attachment 335509 [details] [review]
Change short cut key on Accounts page.

Had a look at this one and it is down to delete key being the short cut for 'Delete Account' on the main menu. This happens on the code, description and notes fields when they are being edited.

This patch changes the short cut to <control>d.

Bob
Comment 2 manekineko 2016-09-14 19:28:34 UTC
While that fixes it, it strikes me as a bit of a hack. When viewing all accounts, the delete key should bring up the window to delete an account. The issue is that shortcut keys shouldn't be active while editing the notes field or other text fields.
Comment 3 Geert Janssens 2016-11-30 16:09:56 UTC
In other words what goes wrong is that either
- the short cut takes precedence over a keystroke in a text field or
- the text field handles the delete key stroke but passes it on

These are gtk related characteristics. I'm not sure gnucash has control over these.
Comment 4 Milan Knizek 2017-06-04 08:22:40 UTC
This appears to be a duplicate of https://bugzilla.gnome.org/show_bug.cgi?id=616709
(I assume "Notes" actually means "Description" in this bug report.)
Comment 5 Geert Janssens 2017-06-06 09:40:59 UTC
(In reply to Milan Knizek from comment #4)
> This appears to be a duplicate of
> https://bugzilla.gnome.org/show_bug.cgi?id=616709
> (I assume "Notes" actually means "Description" in this bug report.)

It is indeed a duplicate although "Notes" really means "Notes". The issue actually happens in both cases.

I had added my thoughts on how this should be fixed in the other bug report, so I will mark this one as the duplicate. Thanks for pointing this out.

*** This bug has been marked as a duplicate of bug 616709 ***
Comment 6 Geert Janssens 2017-06-06 09:42:25 UTC
Comment on attachment 335509 [details] [review]
Change short cut key on Accounts page.

As mentioned in the bug comments already, this is a workaround rather than a proper solution. The solution should be do disable the key binding while any cell is in edit mode.
Comment 7 John Ralls 2018-06-29 23:48:36 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=765221. Please update any external references or bookmarks.