After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765212 - allocator: clean up allocators in gst_deinit()
allocator: clean up allocators in gst_deinit()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-18 13:52 UTC by Guillaume Desmottes
Modified: 2016-04-18 15:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
allocator: add cleanup method (2.52 KB, patch)
2016-04-18 13:53 UTC, Guillaume Desmottes 		committed Details | Review
allocator: chain-up sysmmem finalize method (857 bytes, patch)
2016-04-18 15:24 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2016-04-18 13:52:46 UTC 
While working on bug #765052 I noticed that the memory allocators were not properly cleaned when calling gst_deinit(), making leaks tracking harder.
Comment 1 Guillaume Desmottes 2016-04-18 13:53:31 UTC 
Created attachment 326257 [details] [review]
allocator: add cleanup method

Make tracking memory leaks easier.
Comment 2 Nicolas Dufresne (ndufresne) 2016-04-18 14:54:22 UTC 
Review of attachment 326257 [details] [review]:

Looks good.
Comment 3 Nicolas Dufresne (ndufresne) 2016-04-18 15:00:12 UTC 
Comment on attachment 326257 [details] [review]
allocator: add cleanup method

While the patch looks good, we now get:

<invalid>            : (-1) 0x1e10840

When testing with the following pipeline:

GST_TRACE=all gst-launch-1.0 videotestsrc num-buffers=1 ! fakesink
Comment 4 Guillaume Desmottes 2016-04-18 15:24:33 UTC 
Created attachment 326273 [details] [review]
allocator: chain-up sysmmem finalize method

Not doing so confuse gsttrace when the allocator is destroyed.
Comment 5 Nicolas Dufresne (ndufresne) 2016-04-18 15:34:31 UTC 
I have squashed the two commits. Thanks!

Attachment 326257 [details] pushed as 1ea831b - allocator: add cleanup method