GNOME Bugzilla – Bug 765186
bootstrap: Install gcc-arm-linux-gnueabi if building for ARM linux
Last modified: 2018-11-03 10:20:48 UTC
Created attachment 326211 [details] [review] Patch that adds gcc-arm-linux-gnueabi to bootstrap for linux/arm When building for ARM Linux, Cerbero should install gcc-arm-linux-gnueabi during bootstrap phase, otherwise compilations will fail.
Review of attachment 326211 [details] [review]: This is updating for a single distribution. But before we go to far in review, which case needs this ? Will it conflict with toolchain for Android and iOS builds ?
The rationale behind this is that if I do ./cerbero-uninstalled -c config/cross-lin-arm.cbc bootstrap I expect it will fetch all necessary tools, as it happens with all other configs, instead of crashing with unreadable error on first build. AFAIK it should not conflict with Android/iOS builds as they use separate toolchains fetched during bootstrap phase (but not via apt-get).
Yes this doesn't conflict with Android/iOS at all.
Ok, then my review is the following, can you do that for Fedora/Arch/etc. No need to test it, we'll fix if there is a problem. If you can't find the package name, or there is no cross-toolchain package, add a warning.
Ok, I've been using Fedora last time in 2010, I have to see how it goes and I'll update the patch.
(In reply to Marcin Lewandowski from comment #5) > Ok, I've been using Fedora last time in 2010, I have to see how it goes and > I'll update the patch. For Fedora, package is called "gcc-arm-linux-gnu". If unsure, just add a assertions, we'll fix when we hit that (it's trivial fix after all).
Note that to be extra complete, we'd need to introduce a way to create a sysroot in the bootstrap, is that you intention ? That of course only apply to distro with ARM support.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/cerbero/issues/30.