After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765089 - nm-applet core dumped when asking for new passphrase if secret is stored in gnome key ring
nm-applet core dumped when asking for new passphrase if secret is stored in g...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-applet
1.1.x
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
: 768430 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-04-15 09:18 UTC by zebul666
Modified: 2016-07-05 12:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] applet: fix crash in applet-agent.c (1.26 KB, patch)
2016-06-06 12:32 UTC, Beniamino Galvani 		none Details | Review

Description zebul666 2016-04-15 09:18:23 UTC 
I had my wifi passphrase stored in gnome key ring. (only for the current user option)

I changed the wifi passphrase on the acces point

And nm-applet crashes when asking for the new passphrase:
nm-applet-Message: New secrets for XT1039/802-11-wireless-security requested; ask the user
**
GLib:ERROR:/build/glib2.0-t9oPgV/glib2.0-2.48.0/./glib/gvarianttypeinfo.c:163:g_variant_type_info_check: assertion failed: (info->alignment == 0 || info->alignment == 1 || info->alignment == 3 || info->alignment == 7)

Thread 1 "nm-applet" received signal SIGABRT, Aborted.

This does not happen if the passphrase is not stored in gnome key ring

(gdb) bt

+ Trace 236180

  • #0 __GI_raise
    at ../sysdeps/unix/sysv/linux/raise.c line 54
  • #1 __GI_abort
    at abort.c line 89
  • #2 g_assertion_message
    from /lib/x86_64-linux-gnu/libglib-2.0.so.0
  • #3 g_assertion_message_expr
    from /lib/x86_64-linux-gnu/libglib-2.0.so.0
  • #4 ??
    from /lib/x86_64-linux-gnu/libglib-2.0.so.0
  • #5 g_variant_type_info_get_type_string
    from /lib/x86_64-linux-gnu/libglib-2.0.so.0
  • #6 g_variant_is_of_type
    from /lib/x86_64-linux-gnu/libglib-2.0.so.0
  • #7 nm_connection_update_secrets
    from /usr/lib/x86_64-linux-gnu/libnm.so.0
  • #8 ??
  • #9 g_simple_async_result_complete
    from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
  • #10 ??
    from /usr/lib/x86_64-linux-gnu/libsecret-1.so.0
  • #11 g_simple_async_result_complete
    from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
  • #12 ??
    from /usr/lib/x86_64-linux-gnu/libsecret-1.so.0
  • #13 ??
    from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
  • #14 ??
    from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
  • #15 ??
    from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
  • #16 ??
    from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
  • #17 ??
    from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
  • #18 ??
    from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
  • #19 ??
    from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
  • #20 ??
    from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
  • #21 g_main_context_dispatch
    from /lib/x86_64-linux-gnu/libglib-2.0.so.0
  • #22 ??
    from /lib/x86_64-linux-gnu/libglib-2.0.so.0
  • #23 g_main_context_iteration
    from /lib/x86_64-linux-gnu/libglib-2.0.so.0
  • #24 g_application_run
    from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
  • #25 main 

using network-manager-gnome 1.1.93-1ubuntu1 on ubuntu 16.04
Comment 1 axrg394578 2016-06-03 12:54:57 UTC 
I have also seen exactly this error on a stripped-down lxde installation. Steps to reproduce:
- Wifi network selected from nm-applet
- Incorrect password entered
- Continue pressed to skip setting up password for keyring
- Continue pressed to store passwords unencrypted
- nm-applet shows green dots and rotating arrow for a while then disappears

Debugging shows exactly the error above.
Comment 2 axrg394578 2016-06-03 13:00:24 UTC 
Looks like the same here: http://bandshed.net/forum/index.php?topic=3746.0
and here: http://osdir.com/ml/general/2016-04/msg34986.html
Comment 3 Beniamino Galvani 2016-06-06 12:32:29 UTC 
Created attachment 329187 [details] [review]
[PATCH] applet: fix crash in applet-agent.c
Comment 4 Thomas Haller 2016-06-06 23:03:37 UTC 
(In reply to Beniamino Galvani from comment #3)
> Created attachment 329187 [details] [review] [review]
> [PATCH] applet: fix crash in applet-agent.c

looks right, but it leaks the returned @setting_dict variant.
Comment 5 Beniamino Galvani 2016-06-07 11:42:58 UTC 
(In reply to Thomas Haller from comment #4)
> (In reply to Beniamino Galvani from comment #3)
> > Created attachment 329187 [details] [review] [review] [review]
> > [PATCH] applet: fix crash in applet-agent.c
> 
> looks right, but it leaks the returned @setting_dict variant.

Fixed and applied to master:

https://git.gnome.org/browse/network-manager-applet/commit/?id=91d83b708c599f89079ad108898e20696fc3448b

nma-1-2:

https://git.gnome.org/browse/network-manager-applet/commit/?h=nma-1-2&id=ab3659284ea7cca3086746c81c2060eead05d8c8
Comment 6 axrg394578 2016-06-08 06:11:20 UTC 
Awesome - thanks!
Comment 7 Beniamino Galvani 2016-07-05 12:05:32 UTC 
*** Bug 768430 has been marked as a duplicate of this bug. ***