After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765038 - Adwaita & decorations
Adwaita & decorations
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-04-14 09:57 UTC by Alberts Muktupāvels
Modified: 2016-08-28 13:28 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Alberts Muktupāvels 2016-04-14 09:57:13 UTC
Should not Adwaita "reset" rounded corners also for maximized windows? Just like it is done with fullscreen and tiled windows?

.fullscreen decoration, .maximized decoration, .tiled decoration {}
Comment 1 Matthias Clasen 2016-04-14 14:29:52 UTC
Bugzilla is not the best forum for questions. I recommend #gnome-design on irc
Comment 2 Lapo Calamandrei 2016-04-15 20:02:46 UTC
I don't get what the issue is, would you provide a screenshot?
Maximized windows corners are not squared here.
Comment 3 Lapo Calamandrei 2016-04-15 20:03:35 UTC
ehm, I wanted to mean, "are not *rounded* here"
Comment 4 Alberts Muktupāvels 2016-04-15 20:40:16 UTC
My original problem was because I have added custom css in gtk.css:
decoration { border: 6px ...; }

Then this border had rounded corners, but since Adwaita does not set border this probably is not bug. But most likely it would not hurt to add also:
.maximized decoration { border-radius: 0; }

There already is .fullscreen decoration and .titled decoration that resets rounded corners.

Not related to my original problem, but:
- gedit has rounded corners when maximized
- gnome-software has top right corner rounded when maximized

This is with gtk-3-20 branch.
Comment 5 Lapo Calamandrei 2016-04-16 10:09:06 UTC
Well, even if nothing visible changes it's formaly more correct to have the decoration node following the window shape. Thanks for spotting the other two bugs, anyway next time please file individual bugs please.

Fixed in both master and gtk 3.20 branch, commits 8ee4e45f8a9ded46aa02f0f7bc8cd8267d7d4399 and c961962ce66cc5a2d3e25f6503017f3c3351b6fa respectively.
Comment 6 Daniel Boles 2016-08-28 13:25:42 UTC
(In reply to Lapo Calamandrei from comment #2)
> I don't get what the issue is, would you provide a screenshot?
> Maximized windows corners are not squared [sic: rounded] here.

Is it, then, intentional that if one has the Top Bar visible - as everyone does until they install a plugin to autohide it - that IT has rounded corners, and those corners are stacked above windows, including maximised ones, making said windows _seem_ to have rounded corners?
Comment 7 Daniel Boles 2016-08-28 13:28:35 UTC
(In reply to db0451 from comment #6)

nvm, it is:
https://bugzilla.gnome.org/show_bug.cgi?id=747246