After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765036 - backend: Fix the build with -Werror=format
backend: Fix the build with -Werror=format
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
: 767374 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-04-14 09:30 UTC by Kalev Lember
Modified: 2016-06-08 10:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
backend: Fix the build with -Werror=format (917 bytes, patch)
2016-04-14 09:30 UTC, Kalev Lember
committed Details | Review

Description Kalev Lember 2016-04-14 09:30:13 UTC
On F24 i686 builders totem 3.20.1 fails to build with:

bacon-video-widget.c: In function 'bvw_handle_toc_message':
bacon-video-widget.c:2337:18: error: format '%li' expects argument of type 'long int', but argument 9 has type 'gint64 {aka long long int}' [-Werror=format=]
       GST_DEBUG ("Chapter #%d (start: %li stop: %li)", i, start, stop);
                  ^
/usr/include/gstreamer-1.0/gst/gstinfo.h:546:31: note: in definition of macro 'GST_CAT_LEVEL_LOG'
         (GObject *) (object), __VA_ARGS__);    \
                               ^~~~~~~~~~~
bacon-video-widget.c:2337:7: note: in expansion of macro 'GST_DEBUG'
       GST_DEBUG ("Chapter #%d (start: %li stop: %li)", i, start, stop);
       ^
bacon-video-widget.c:2337:18: error: format '%li' expects argument of type 'long int', but argument 10 has type 'gint64 {aka long long int}' [-Werror=format=]
       GST_DEBUG ("Chapter #%d (start: %li stop: %li)", i, start, stop);
                  ^
/usr/include/gstreamer-1.0/gst/gstinfo.h:546:31: note: in definition of macro 'GST_CAT_LEVEL_LOG'
         (GObject *) (object), __VA_ARGS__);    \
                               ^~~~~~~~~~~
bacon-video-widget.c:2337:7: note: in expansion of macro 'GST_DEBUG'
       GST_DEBUG ("Chapter #%d (start: %li stop: %li)", i, start, stop);
Comment 1 Kalev Lember 2016-04-14 09:30:37 UTC
Created attachment 325984 [details] [review]
backend: Fix the build with -Werror=format
Comment 2 Philip Withnall 2016-04-14 10:17:11 UTC
Review of attachment 325984 [details] [review]:

Great.
Comment 3 Kalev Lember 2016-04-14 11:08:37 UTC
Attachment 325984 [details] pushed as 057590c - backend: Fix the build with -Werror=format
Comment 4 Bastien Nocera 2016-06-08 10:56:35 UTC
*** Bug 767374 has been marked as a duplicate of this bug. ***