GNOME Bugzilla – Bug 765034
MSVC builds: Improve how introspection is done
Last modified: 2016-04-18 05:43:23 UTC
Hi, Currently, on GDK-Pixbuf, introspection is done on Visual Studio builds in the following manner: -A Python script is first run to read gdk-pixbuf/Makefile.am to create the list of files to be introspected. -g-ir-scanner is called with a hand-written command line to build the .gir -Another hand-written command line is used to compile the .gir into the .typelib This works for our purposes, but is not optimal in terms of maintenance. This bug attempts to make the file list generation, along with generating the command lines for building the .gir/.typelib, done during 'make dist'. With blessings, thank you!
Created attachment 325981 [details] [review] build: Add common autotools module for generating items needed for building introspection on Visual Studio builds Hi, This is the same autotools module that is used in ATK, Pango, libsoup and GtkSourceview, which is used during 'make dist' to: -Generate the list of files to introspect -Generate the full command lines for g-ir-scanner and g-ir-compiler to build the .gir/.typelib files as a NMake Makefile snippet...
Created attachment 325982 [details] [review] MSVC builds: Generate the file list and command lines for introspection Hi, This makes use of the autotools module in the previous comment so that the file list and command lines used to build introspection can be generated during 'make dist'. This will also make the NMake Makefile modules to be in line with those used in GObject-Introspection and move the NMake Makefiles to build/win32, to make things more consistent across the board and easier to maintain. With blessings, thank you!
Review of attachment 325981 [details] [review]: Sure
Review of attachment 325982 [details] [review]: as usual, double check distcheck passes. Go ahead if so.
Hi Nacho, (Sorry for not posting back here earlier after pushing the items) The patches were pushed as, after checking with 'make -j8 distcheck': -325981: d90105d -325982: 0a4d00c Thanks for the review, with blessings, and cheers!