After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765031 - soup: Work-around varargs GType passing bugs on Windows 10 / 64 bit
soup: Work-around varargs GType passing bugs on Windows 10 / 64 bit
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.8.0
Other Windows
: Normal critical
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-14 07:06 UTC by Sebastian Dröge (slomo)
Modified: 2016-04-14 11:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
souphttpsrc: Work around varargs GType passing bug on Windows 10 / 64 bit (1.16 KB, patch)
2016-04-14 07:07 UTC, Sebastian Dröge (slomo) 		rejected Details | Review
souphttpclientsink: Add default proxy resolver to the session if no proxy was given by property (1.06 KB, patch)
2016-04-14 07:07 UTC, Sebastian Dröge (slomo) 		rejected Details | Review

Description Sebastian Dröge (slomo) 2016-04-14 07:06:17 UTC 
+++ This bug was initially created as a clone of Bug #758738 +++

See linked bug and attached patch(es).
Comment 1 Sebastian Dröge (slomo) 2016-04-14 07:07:33 UTC 
Created attachment 325896 [details] [review]
souphttpsrc: Work around varargs GType passing bug on Windows 10 / 64 bit
Comment 2 Sebastian Dröge (slomo) 2016-04-14 07:07:38 UTC 
Created attachment 325897 [details] [review]
souphttpclientsink: Add default proxy resolver to the session if no proxy was given by property
Comment 3 Ignacio Casal Quinteiro (nacho) 2016-04-14 07:15:06 UTC 
Review of attachment 325896 [details] [review]:

See comment

::: ext/soup/gstsouphttpsrc.c
@@ +956,2 @@
           SOUP_SESSION_TLS_INTERACTION, src->tls_interaction, NULL);
+      soup_session_add_feature_by_type (src->session,

wrong indentation?
Comment 4 Ignacio Casal Quinteiro (nacho) 2016-04-14 07:16:01 UTC 
Review of attachment 325896 [details] [review]:

Nah skip my comment.
Comment 5 Sebastian Dröge (slomo) 2016-04-14 11:44:41 UTC 
Proper bugfix is in the original bug for GLib now... this one had no effect anyway.