After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764957 - dvbsrc: support dvbv5 channels format
dvbsrc: support dvbv5 channels format
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-12 14:06 UTC by Thiago Sousa Santos
Modified: 2016-06-25 09:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dvbbasebin: also accept DVBv5 channels.conf format (13.71 KB, patch)
2016-04-12 14:07 UTC, Thiago Sousa Santos 		committed Details | Review
dvb/parsechannels: fix dvbv5 modulation names (1.76 KB, patch)
2016-04-13 04:19 UTC, Reynaldo H. Verdejo Pinochet 		committed Details | Review

Description Thiago Sousa Santos 2016-04-12 14:06:07 UTC 
Currently dvbsrc supports only reading the channels.conf file in the old zap format. It would be nice to also support the new format that is more complete and readable. Some details can be found at this link:

https://www.linuxtv.org/wiki/index.php/Dvbv5-scan
Comment 1 Thiago Sousa Santos 2016-04-12 14:07:55 UTC 
Created attachment 325808 [details] [review]
dvbbasebin: also accept DVBv5 channels.conf format

This patch allows reading and using libdvbv5 channels format, it uses the old
format as a fallback when parsing fails for some reason.

It also was only tested for ISDB-T so some fields might be missing to have it
working with other standards. It would be nice if someone could try this and
add any missing fields to have it working for their regions.
Comment 2 Reynaldo H. Verdejo Pinochet 2016-04-13 04:19:39 UTC 
Created attachment 325837 [details] [review]
dvb/parsechannels: fix dvbv5 modulation names

Patch builds on Thiago's and fixes it for ATSC

The idea of adding dvbv5 file parsing capabilities is indeed quite
useful. Some of the delivery systems can only be supported properly
by moving out of the loosely defined ZAP format so in general: +1 from me.

It might also be a good idea to double check the labels/names
for the rest of the parameters are OK before pushing though.
Comment 3 Thiago Sousa Santos 2016-04-19 21:04:09 UTC 
Any other opinions on this new feature?
Comment 4 Russel Winder 2016-05-17 12:16:25 UTC 
The patches can no longer be applied by "git apply" due to subsequent changes in the repository.
Comment 5 Reynaldo H. Verdejo Pinochet 2016-06-25 01:42:23 UTC 
Pushed.
Comment 6 Reynaldo H. Verdejo Pinochet 2016-06-25 01:45:17 UTC 
Review of attachment 325808 [details] [review]:

Patch updated and committed as:

dc93c448ca0744 dvbbasebin: also accept DVBv5 channels.conf format
Comment 7 Reynaldo H. Verdejo Pinochet 2016-06-25 01:48:52 UTC 
Review of attachment 325837 [details] [review]:

Pushed.