GNOME Bugzilla – Bug 764921
segfault when unable to find a cached icon
Last modified: 2016-05-28 20:01:48 UTC
In gs-appstream.c, we have this code: if (icon == NULL) { g_warning ("failed to find cached icon %s", as_icon_get_name (icon)); return; } this code gets executed, then we call as_icon_get_name (NULL), leading to a crash. Downstream bug -> https://bugzilla.opensuse.org/show_bug.cgi?id=974806
Created attachment 325753 [details] [review] Proposed patch.
commit 33e099bd18a51b50348d5ed38b2a620eb159b669 Author: Richard Hughes <richard@hughsie.com> Date: Wed Apr 27 19:52:04 2016 +0100 Fix potential crash when icons are missing Resolves: https://bugzilla.gnome.org/show_bug.cgi?id=764921
Thanks a bunch for the fix. Is there any chance we could have this cherry-picked into 3.20 stable branch too?