GNOME Bugzilla – Bug 764897
Using non IPv6-socket in IPv6 scope
Last modified: 2016-04-28 17:34:09 UTC
Created attachment 325730 [details] [review] Attached a patch that suggest a possible fix to the issue. I am getting an assertion (g_socket_get_family: assertion ‘G_IS_SOCKET (socket)’ failed) in gst_multiudpsink_start (gst-plugins-good/gst/udp/gstmultiudpsink.c:1315). It seems that a non IPv6-socket is used. Attached a patch that suggest a possible fix to the issue.
Review of attachment 325730 [details] [review]: ::: gst/udp/gstmultiudpsink.c @@ +1312,3 @@ if (sink->socket_v6) { GST_DEBUG_OBJECT (sink, "using configured IPv6 socket"); + g_return_val_if_fail (g_socket_get_family (sink->socket_v6) == So your problem is that you set "socket-v6" but keep "socket" at NULL? I think this assertion should be (!socket || family(socket) == IPV6, FALSE)
Created attachment 326686 [details] [review] New patch base on the comment from Slomo New patch with code changes based on the comment from Slomo.
Thank you for the input in you comment slomo. I have added a new patch
Review of attachment 326686 [details] [review]: ::: gst/udp/gstmultiudpsink.c @@ +1313,3 @@ GST_DEBUG_OBJECT (sink, "using configured IPv6 socket"); + g_return_val_if_fail (!sink->socket || (g_socket_get_family (sink->socket) == + G_SOCKET_FAMILY_IPV6), FALSE); This should be !=, not ==. It should fail if there is a ->socket and this ->socket is IPV6.
Created attachment 326720 [details] [review] Updated patch
Comment on attachment 326720 [details] [review] Updated patch This doesn't apply cleanly to latest GIT master. Can you rebase? Also while you're at it, the parenthesis around the x != y are unneeded :) You said that you have a testcase for this, I wonder why it didn't fail with your previous patches that had different logic
Oki, will fix. :-)
I don't get it. Everything is up to date. There is nothing to rebase. :(
Created attachment 326723 [details] [review] Patch after trying to rebase Tried to rebase but everything seems to be updated.
commit 63c284c24ec08c8cdf976f819bcd20868766e57f Author: Mats Lindestam <matslm@axis.com> Date: Mon Apr 25 15:03:14 2016 +0200 multiudpsink: Allow setting "socket-v6" without setting "socket" too https://bugzilla.gnome.org/show_bug.cgi?id=764897