After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764800 - Fixes for several minor issues in Shotwell's documentation
Fixes for several minor issues in Shotwell's documentation
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: documentation
unspecified
Other All
: Normal normal
: ---
Assigned To: Shotwell Maintainers
Shotwell Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-08 17:16 UTC by Rafael Fontenelle
Modified: 2016-04-16 08:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH 1/4] Removed execution permissions of formats page (569 bytes, patch)
2016-04-08 17:16 UTC, Rafael Fontenelle
committed Details | Review
[PATCH 2/4] Fixed mentions to UI's option/item/button labels (13.58 KB, patch)
2016-04-08 17:16 UTC, Rafael Fontenelle
committed Details | Review
[PATCH 3/4] Add '<gui>' tag to option/item/button mentions (3.01 KB, patch)
2016-04-08 17:17 UTC, Rafael Fontenelle
committed Details | Review
[PATCH 4/4] Change "Date and Time" help's page filename to fit its content (3.90 KB, patch)
2016-04-08 17:17 UTC, Rafael Fontenelle
committed Details | Review

Description Rafael Fontenelle 2016-04-08 17:16:18 UTC
Created attachment 325600 [details] [review]
[PATCH 1/4] Removed execution permissions of formats page

While translating Shotwell's Help files, some errors were spotted -- thanks Felipe Braga. Therefore, I made some git formatted-patches hoping to solve them. Their commit messages very descriptive information of what each patches do, but let me know if more information is required.

Please review them.
Comment 1 Rafael Fontenelle 2016-04-08 17:16:54 UTC
Created attachment 325601 [details] [review]
[PATCH 2/4] Fixed mentions to UI's option/item/button labels
Comment 2 Rafael Fontenelle 2016-04-08 17:17:19 UTC
Created attachment 325602 [details] [review]
[PATCH 3/4] Add '<gui>' tag to option/item/button mentions
Comment 3 Rafael Fontenelle 2016-04-08 17:17:45 UTC
Created attachment 325603 [details] [review]
[PATCH 4/4] Change "Date and Time" help's page filename to fit its content
Comment 4 Jens Georg 2016-04-15 21:50:45 UTC
Review of attachment 325601 [details] [review]:

Looks good. Regarding ..., what's the general policy here? use three . or the unicode … ?
Comment 5 Jens Georg 2016-04-15 21:51:18 UTC
Review of attachment 325602 [details] [review]:

+1
Comment 6 Jens Georg 2016-04-15 21:51:47 UTC
Review of attachment 325603 [details] [review]:

+1
Comment 7 Rafael Fontenelle 2016-04-15 22:19:19 UTC
GNOME normally uses the three-dots character '...' (U+2026). I used three '.' characteres as this is what is used in the Shotwell's UI, but I suggest migrating both UI and Docs to the first one (U+2026).
Comment 8 Rafael Fontenelle 2016-04-15 22:20:25 UTC
Please read '…' instead of '...' in my reply.
Comment 9 Jens Georg 2016-04-16 08:16:10 UTC
(In reply to Rafael Fontenelle from comment #7)
> GNOME normally uses the three-dots character '...' (U+2026). I used three
> '.' characteres as this is what is used in the Shotwell's UI, but I suggest
> migrating both UI and Docs to the first one (U+2026).

Ok. I'll make a new task for this, thanks.