After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764797 - Passthrough nodes should let the input format go through as well
Passthrough nodes should let the input format go through as well
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks: 764801
 
 
Reported: 2016-04-08 15:56 UTC by Debarshi Ray
Modified: 2016-04-18 13:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
operation: Let the source format go through for passthrough nodes (981 bytes, patch)
2016-04-08 16:05 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2016-04-08 15:56:52 UTC 
Consider a graph like this:
  src -> passthrough_node -> op

If passthrough_node doesn't let the format through, then op will get NULL as its source format in its prepare vfunc. That is problematic for operations that reconfigure themselves depending on the source format.
Comment 1 Debarshi Ray 2016-04-08 16:05:08 UTC 
Created attachment 325598 [details] [review]
operation: Let the source format go through for passthrough nodes
Comment 2 Debarshi Ray 2016-04-18 13:35:05 UTC 
From #gegl on GIMPNet:

13:21 <rishi> Do you think https://bugzilla.gnome.org/show_bug.cgi?id=764795    
      and https://bugzilla.gnome.org/show_bug.cgi?id=764797 are OK to push?
13:21 <rishi> The test suite passes.
13:22 <rishi> I keep asking because a gnome-photos patch series needs           
      them. See the "blocks field.
13:28 <pippin> rishi: just push :)
13:29 <rishi> pippin: Ok. Pushing.
Comment 3 Debarshi Ray 2016-04-18 13:35:35 UTC 
commit 270a3da33550bf5b252b9df128df56a961f47ed2
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Fri Apr 8 18:04:37 2016 +0200

    operation: Let the source format go through for passthrough nodes
    
    https://bugzilla.gnome.org/show_bug.cgi?id=764797