GNOME Bugzilla – Bug 764791
gitypelib.c: increase #define MAX_NAME_LEN from 200 to 255
Last modified: 2017-12-19 18:56:32 UTC
MAX_NAME_LEN should be increased to 255 from current 200 value. This length is not sufficient sometimes while dealing with generated names from yang tool chain etc. File girepository/gi_typelib.c #define MAX_NAME_LEN 200 <-- should be changed to 255
We could, as far as I can see nothing is really using this. I don't think there are any real limits on string size. The internet seems to imply 2048 would be more reasonable: http://stackoverflow.com/questions/6007568/what-is-max-length-for-an-c-c-identifier-on-common-build-systems But even if we fixed it you wouldn't be able to use it until you had a new g-i.
Created attachment 331259 [details] [review] Expand MAX_NAME_LEN to 2048 This patch expands the MAX_NAME_LEN from 200 to 2048, based on feedback here and the referenced Stack Overflow discussion.
Can this be implemented - it is a trivial change and should have no impact on functionality, but it would mean that in the future we don't need to maintain a fork of gobject-introspection just so we can have the longer MAX_NAME_LEN.
Review of attachment 331259 [details] [review]: Thanks for your patience. Could you please attach a new patch, made by `git format-patch` or, better, `git-bz`? This would speed up the review and attribution process.
Created attachment 362923 [details] [review] bug-764791: increase MAX_NAME_LEN
It would be good to know what timeframe I should expect this to be included in. If there is anything else I can do please let me know - this should be a trivial change.
Any update on this?
Review of attachment 362923 [details] [review]: Hi, thanks again. The commit message is a bit scarce. The typical format is explained here: https://wiki.gnome.org/Git/CommitMessages I've taken the liberty of avoiding another round of review, and pushed an amended commit message.
Pushed attachment 362923 [details] [review] as 017e172150de75238c521b7c87f224aa8316026b with an amended commit