After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764688 - Couple of fixes from a coverity scan
Couple of fixes from a coverity scan
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: at-spi2-core
unspecified
Other All
: Normal normal
: ---
Assigned To: At-spi maintainer(s)
At-spi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-04-06 15:22 UTC by Rui Matos
Modified: 2016-04-14 11:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
registryd: Avoid crashing with a NULL keystring (1.89 KB, patch)
2016-04-06 15:22 UTC, Rui Matos 		committed Details | Review
atspi-event-listener: Plug a memory leak (881 bytes, patch)
2016-04-06 15:22 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2016-04-06 15:22:01 UTC 
.
Comment 1 Rui Matos 2016-04-06 15:22:04 UTC 
Created attachment 325489 [details] [review]
registryd: Avoid crashing with a NULL keystring

From a coverity check:

1. at-spi2-core-2.14.1/registryd/deviceeventcontroller-x11.c:1167:
deref_ptr_in_call: Dereferencing pointer "keystring".
2. at-spi2-core-2.14.1/registryd/deviceeventcontroller-x11.c:1169:
check_after_deref: Null-checking "keystring" suggests that it may be
null, but it has already been dereferenced on all paths leading to the
check.
(keystring, -1, &c))) {
Comment 2 Rui Matos 2016-04-06 15:22:10 UTC 
Created attachment 325490 [details] [review]
atspi-event-listener: Plug a memory leak
Comment 3 Mike Gorse 2016-04-11 16:09:41 UTC 
Comment on attachment 325489 [details] [review]
registryd: Avoid crashing with a NULL keystring

pushed to master: bb8118
Comment 4 Mike Gorse 2016-04-11 16:15:34 UTC 
Comment on attachment 325490 [details] [review]
atspi-event-listener: Plug a memory leak

pushed to master: b30d42
Comment 5 Mike Gorse 2016-04-11 16:18:01 UTC 
Thanks for the patches. I've pushed to master and will include them for 2.20.1.
Comment 6 Simon McVittie 2016-04-14 06:25:32 UTC 
These appear to have been released in 2.20.1, but there's no 2.20.1 tag in git. Did you forget to push?
Comment 7 Mike Gorse 2016-04-14 11:29:24 UTC 
(In reply to Simon McVittie from comment #6)
> These appear to have been released in 2.20.1, but there's no 2.20.1 tag in
> git. Did you forget to push?


APparently. Sorry about that. Pushed now.