After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764681 - Disable "Add to album" button on the top-level Albums view
Disable "Add to album" button on the top-level Albums view
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-04-06 13:35 UTC by Rafael Fonseca
Modified: 2016-04-19 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
selection-toolbar: disable collection nesting (886 bytes, patch)
2016-04-15 14:30 UTC, Rafael Fonseca 		committed Details | Review

Description Rafael Fonseca 2016-04-06 13:35:34 UTC 
We don't want albums hierarchy. So the button should be removed/disable from the Album view.
Comment 1 Alessandro Bono 2016-04-08 09:13:22 UTC 
Relevant commit from Documents:
https://git.gnome.org/browse/gnome-documents/commit/?id=06636dc63122f2a0ac04f21441afa8f5028d8ee9
Comment 2 Rafael Fonseca 2016-04-15 14:30:20 UTC 
Created attachment 326105 [details] [review]
selection-toolbar: disable collection nesting
Comment 3 Debarshi Ray 2016-04-19 16:05:15 UTC 
Review of attachment 326105 [details] [review]:

Thanks, Rafael. Looks good to me.
Comment 4 Debarshi Ray 2016-04-19 16:07:53 UTC 
Although, there is one difference with gnome-documents. There we completely hide the button instead of disabling it. Note that in commit 256061e7e5017732ae08a6266ae89fc1f570ec5a we switched from hiding the buttons to disabling them.

We should probably get this clarified from the designers and open further bugs as necessary.
Comment 5 Rafael Fonseca 2016-04-19 16:16:41 UTC 
(In reply to Debarshi Ray from comment #4)
> Although, there is one difference with gnome-documents. There we completely
> hide the button instead of disabling it. Note that in commit
> 256061e7e5017732ae08a6266ae89fc1f570ec5a we switched from hiding the buttons
> to disabling them.
> 
> We should probably get this clarified from the designers and open further
> bugs as necessary.

The selection toolbar might be active during a search. The results of a search might include single photos as well as albums. So showing/hiding the button when an album is selected/unselected might be a concern.