After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764680 - Disable favouriting albums
Disable favouriting albums
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-04-06 13:33 UTC by Rafael Fonseca
Modified: 2016-04-21 06:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
base-item: disable favoriting for collections (1.00 KB, patch)
2016-04-15 14:16 UTC, Rafael Fonseca 		committed Details | Review
selection-toolbar: disable favorite button for collections (952 bytes, patch)
2016-04-15 14:17 UTC, Rafael Fonseca 		committed Details | Review
selection-toolbar: Disable favorites button for albums (978 bytes, patch)
2016-04-19 16:22 UTC, Debarshi Ray 		committed Details | Review
base-item: Disable favorite albums when reading from the database (2.55 KB, patch)
2016-04-19 17:04 UTC, Debarshi Ray 		committed Details | Review
search-type-manager: Only query nmm:Photo instances for favorites (1.36 KB, patch)
2016-04-19 17:05 UTC, Debarshi Ray 		none Details | Review
search-type-manager: Only query nmm:Photo instances for favorites (2.33 KB, patch)
2016-04-19 22:33 UTC, Debarshi Ray 		committed Details | Review

Description Rafael Fonseca 2016-04-06 13:33:01 UTC 
There wasn't too much thought behind allowing albums to belong to favourites. The consensus is that we should only be able to favourite photos.
Comment 1 Rafael Fonseca 2016-04-15 14:16:45 UTC 
Created attachment 326103 [details] [review]
base-item: disable favoriting for collections
Comment 2 Rafael Fonseca 2016-04-15 14:17:08 UTC 
Created attachment 326104 [details] [review]
selection-toolbar: disable favorite button for collections
Comment 3 Debarshi Ray 2016-04-19 16:21:43 UTC 
Review of attachment 326103 [details] [review]:

Thanks, Rafael. Pushed.
Comment 4 Debarshi Ray 2016-04-19 16:22:59 UTC 
Created attachment 326339 [details] [review]
selection-toolbar: Disable favorites button for albums

Pushed after rebasing.
Comment 5 Debarshi Ray 2016-04-19 17:04:42 UTC 
Created attachment 326342 [details] [review]
base-item: Disable favorite albums when reading from the database
Comment 6 Debarshi Ray 2016-04-19 17:05:07 UTC 
Created attachment 326343 [details] [review]
search-type-manager: Only query nmm:Photo instances for favorites
Comment 7 Rafael Fonseca 2016-04-19 17:16:11 UTC 
Review of attachment 326343 [details] [review]:

We can also get rid of fav_filter altogether, no?
Comment 8 Debarshi Ray 2016-04-19 22:33:05 UTC 
Created attachment 326363 [details] [review]
search-type-manager: Only query nmm:Photo instances for favorites

Remove fav_filter, which is now unused.