GNOME Bugzilla – Bug 764675
Follow GNOME coding style for examples
Last modified: 2021-07-05 10:53:37 UTC
Created attachment 325468 [details] [review] Follow GNOME C coding style. (aboutdialog.c) Though several things seem trivial, as these examples are intended to teach, it should be written as good as possible. Fixing one of the file (aboutdialog.c). I shall add more patches if someone says its worth. Thank you.
Review of attachment 325468 [details] [review]: Rather than improving the coding style of the examples, it owuld be more productive to remove the outdated content and start from scratch. However, the patch is fine. ::: platform-demos/C/samples/aboutdialog.c @@ +42,3 @@ + + /* We do not wish to show the title, which in this case would be + * "AboutDialog Example". We have to reset the title of the messagedialog I do not think that leaving two spaces after a full stop in comments is mentioned in the programming guidelines, although I might have missed it. In any case, I would be against making such a change.
Two spaces after end of a sentence is common for English. It's also standardized in GNU standards. See http://www.gnu.org/prep/standards/standards.html#Comments Also, some editors (like GNU Emacs) take care about such conditions as end of a sentence.
OK, that is good for a reference, but does not change my opinion about the number of spaces after a full stop. Please change it to one.
Created attachment 325470 [details] [review] Follow GNOME C coding style. (aboutdialog.c) Two spaces now reduced to one. Anyway, as you said, I shall try to find outdated contents and fix, where I can. Thank you.
Review of attachment 325470 [details] [review]: Thanks for the updated patch. I modified the commit message slightly, and pushed it to master as commit cf4ef5cf42e5a33009e5a25b764ed34b40dabc13.
Created attachment 325624 [details] [review] replace deprecated gtk_scrolled_window_add_with_viewport
Review of attachment 325624 [details] [review]: Sure, seems fine.
Comment on attachment 325624 [details] [review] replace deprecated gtk_scrolled_window_add_with_viewport Pushed that last "accepted commit now" patch as git commit ce91dfd9. Anything else left to do here?
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/gnome-devel-docs/-/issues/ Thank you for your understanding and your help.