After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764595 - Inverse Scrolling in Wayland Session on Charmap and Font Selection
Inverse Scrolling in Wayland Session on Charmap and Font Selection
Status: RESOLVED FIXED
Product: gucharmap
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gucharmap maintainers
gucharmap maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-04 15:31 UTC by Gabriel Rauter
Modified: 2016-05-03 06:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] gucharmap: Use smooth scroll mask (1.08 KB, patch)
2016-05-02 15:05 UTC, Olivier Fourdan
committed Details | Review

Description Gabriel Rauter 2016-04-04 15:31:44 UTC
When using gucharmap 8.0.0 in a gnome wayland session both the Charmap and the Font Selection widget scroll in the wrong direction when using the mouse wheel. Other widgets like the script selector scroll in the direction set in the Gnome System Settings direction.

Enabling Natural Scrolling in the Gnome System Settings inverses the scrolling behavior.
Comment 1 Christian Persch 2016-04-15 16:18:04 UTC
The font selection widget is just an ordinary GtkComboBox, and the chartable is just using the GtkScrolledWindow's scrolling, so if anything is wrong, it's due to gtk+.

-> gtk+
Comment 2 Gabriel Rauter 2016-04-16 15:02:02 UTC
Like i said other elements scroll as intended. The problem probably is how chartable implements the GtkScrollable interface, because the Character Details  notebook page which is a GtkTextView in a GtkScrolledWindow scrolls correctly.
Comment 3 Olivier Fourdan 2016-05-02 12:52:13 UTC
Here, it doesn't scroll with the touchpad either whereas other widgets do.
Comment 4 Matthias Clasen 2016-05-02 13:30:40 UTC
the main contents (charmap ?) doesn't scroll at all with touchpad/touchscreen here.

The comboboxes and treeview behave as expeted for me, wrt to inverse scrolling
Comment 5 Matthias Clasen 2016-05-02 13:31:52 UTC
Moving back to have the charmap scrolling looked at.
Comment 6 Christian Persch 2016-05-02 14:03:55 UTC
> The problem probably is how
> chartable implements the GtkScrollable interface

GucharmapChartable just uses the value-changed signal on the GtkAdjustment, nothing special; afaik it's the GtkScrollbar/GtkScrolledWindow that's translating scroll events to adjustment changes.

As for touch scrolling, I thought GtkScrolledWindow handled that itself, too.
Comment 7 Olivier Fourdan 2016-05-02 15:05:12 UTC
Created attachment 327157 [details] [review]
[PATCH] gucharmap: Use smooth scroll mask

This seems to fix the issue with scrolling with both touchpad and mouse (direction) on Wayland here.
Comment 8 Gabriel Rauter 2016-05-02 15:10:42 UTC
The fix for gucharmap is working for me.
But regarding the Font Selection Widget i also tested it with the touched.
The widget scrolls in the right direction with the touchpad but with rather small steps, it still does scroll in the wrong direction with my mouses wheel tough. In addition the down arrow on the Font Selection widget is off screen. I can still reach it with the cursor but it is not visible.
Comment 9 Olivier Fourdan 2016-05-02 15:23:28 UTC
(In reply to Gabriel Rauter from comment #8)
> The fix for gucharmap is working for me.

OK, so attachment 327157 [details] [review] works for you.

> But regarding the Font Selection Widget i also tested it with the touched.
> The widget scrolls in the right direction with the touchpad but with rather
> small steps, it still does scroll in the wrong direction with my mouses
> wheel tough. In addition the down arrow on the Font Selection widget is off
> screen. I can still reach it with the cursor but it is not visible.

The font selection menu? That's a different issue, attachment 327157 [details] [review] doesn't change anything for that menu.
Comment 10 Olivier Fourdan 2016-05-02 15:53:59 UTC
(In reply to Olivier Fourdan from comment #9)
> The font selection menu? That's a different issue, attachment 327157 [details] [review]
> [details] [review] doesn't change anything for that menu.

Meanwhile I filed bug 765907 for that other issue with GtkMenu.
Comment 11 Christian Persch 2016-05-02 16:03:38 UTC
Comment on attachment 327157 [details] [review]
[PATCH] gucharmap: Use smooth scroll mask

Thanks!
Comment 12 Olivier Fourdan 2016-05-02 17:11:24 UTC
Comment on attachment 327157 [details] [review]
[PATCH] gucharmap: Use smooth scroll mask

attachment 327157 [details] [review] pushed as commit cb9f96f - gucharmap: Use smooth scroll mask
Comment 13 Olivier Fourdan 2016-05-02 17:12:37 UTC
Thanks, I pushed it to master, should I push it to branch gnome-3-20 as well or do you want to do it later when you'll make a new release for 3.20.x?
Comment 14 Christian Persch 2016-05-02 18:33:23 UTC
Fine with me to cherry-pick to 3-20 if you want to.
Comment 15 Olivier Fourdan 2016-05-03 06:48:30 UTC
(In reply to Christian Persch from comment #14)
> Fine with me to cherry-pick to 3-20 if you want to.

Thanks! attachment 327157 [details] [review] cherry-picked as commit 4131ed2 in branch gnome-3-20