GNOME Bugzilla – Bug 764585
Fix "format not a string literal" errors
Last modified: 2016-04-16 16:42:51 UTC
.
Created attachment 325332 [details] [review] ui-manager: Fix "format not a string literal" errors Quite a bit of code movement, but necessary to build with the default format errors produced by newer versions of GCC.
Created attachment 325333 [details] [review] about-dialog: Fix "format not a string literal" errors A non-intrusive fix.
Created attachment 325334 [details] [review] file-chooser-widget: Fix "format not a string literal" error
Created attachment 325335 [details] [review] recent-manager: Fix "format not a string literal" error
Review of attachment 325332 [details] [review]: Looks fine to me
Review of attachment 325333 [details] [review]: ok
Review of attachment 325334 [details] [review]: ok
Review of attachment 325335 [details] [review]: ok
Can you put those on the 3.20 branch too, please ?
Created attachment 325347 [details] [review] cups: Fix "format not a string literal" error
Review of attachment 325347 [details] [review]: This only fixes one half of the problems in this file.
CC:'ing Felipe to finish the patch in comment 10 (it's easy but tedious, and he's young ;)
Attachment 325332 [details] pushed as bf8653c - ui-manager: Fix "format not a string literal" errors Attachment 325333 [details] pushed as a8c5954 - about-dialog: Fix "format not a string literal" errors Attachment 325334 [details] pushed as 6a5224f - file-chooser-widget: Fix "format not a string literal" error Attachment 325335 [details] pushed as becc0d4 - recent-manager: Fix "format not a string literal" error Attachment 325347 [details] pushed as 9336355 - cups: Fix "format not a string literal" error
Created attachment 325805 [details] [review] cups: Fix more "format not a string literal" error
Review of attachment 325805 [details] [review]: Looks fine to me. Please commit to gtk-3-20 and master. Also, it would be good to get rid of those magic numbers in there. I see no reason for bare numbers to be used that way.
Attachment 325805 [details] pushed as 027702e - cups: Fix more "format not a string literal" error
027702e made the strings untranslatable (see the obsolete strings at the end of the file: <https://l10n.gnome.org/POT/gtk+.master/gtk+.master.pl.po>).
Created attachment 325879 [details] [review] cups: make string non-literals translatable again Notice that C_ just takes string literals as arguments.
Review of attachment 325879 [details] [review]: Looks fine.
Attachment 325879 [details] pushed as b0b1bf2 - cups: make string non-literals translatable again
The four strings in question are still not extracted to .pot/.po files. Additionally, I think commit https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-20&id=830626596b5325c836eeb4760ea47cfada9baad2 changed "Printer “%s” is out of developer." to a duplicate of "Printer “%s” is low on developer.".
Created attachment 326077 [details] [review] cups: Fix gettext usage The previous patches didn't mark some strings as to be translated, and tried to translate strings with a variable part already inside the string, which isn't going to work. Mark the strings as translatable with context, and also make sure to translate static strings when getting them out of their structure.
(In reply to Piotr Drąg from comment #21) > The four strings in question are still not extracted to .pot/.po files. > > Additionally, I think commit > https://git.gnome.org/browse/gtk+/commit/?h=gtk-3- > 20&id=830626596b5325c836eeb4760ea47cfada9baad2 changed "Printer “%s” is out > of developer." to a duplicate of "Printer “%s” is low on developer.". Let me know if that patch fixes it for you. My mistake for not reviewing Felipe's patches properly.
Review of attachment 326077 [details] [review]: looks good to me, fwiw
(In reply to Bastien Nocera from comment #23) > Let me know if that patch fixes it for you. My mistake for not reviewing > Felipe's patches properly. It fixes the strings extraction to .po files. Thank you.
Attachment 326077 [details] pushed as a69e591 - cups: Fix gettext usage