After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764543 - /usr/bin/gtkdoc-mkpdf always exits with an error
/usr/bin/gtkdoc-mkpdf always exits with an error
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
1.25
Other Linux
: Normal major
: 1.26
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-03 14:06 UTC by Michael Biebl
Modified: 2016-04-19 18:41 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Michael Biebl 2016-04-03 14:06:21 UTC
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=819886

Quoting gtkdoc-mkpdf.in (and /usr/bin/gtkdoc-mkpdf):
--------------------------
cleanexit() {
    rm -f $module.fo
    exit 1
}
[...]
      echo "dblatex or fop must be installed to use gtkdoc-mkpdf." >&2
      cleanexit 1
    fi
  fi
else
    # not very good output
    # also for xxx-docs.sgml it will produce xxx-docs.pdf
    docbook2pdf -e no-valid "$document"
fi

echo "timestamp" > pdf.stamp
cleanexit 0
--------------------------

So cleanexit() is supposed to take an exitcode as argument but ignores it and exits with 1 instead. Obviously the function definition should read
cleanexit() {
    rm -f $module.fo
    exit $1
}

Whis is exactly how the code looked like in 1.24-2.

This seems to be an unintended change caused by https://git.gnome.org/browse/gtk-doc/commit/?id=12adab6b0a28aec4008c6deed247bf944b5882f2
Comment 1 Michael Biebl 2016-04-03 14:08:03 UTC
Seems important enough to make a new stable release imo.
Comment 2 Michael Biebl 2016-04-18 22:35:54 UTC
Any news?
Comment 3 Matthias Clasen 2016-04-19 13:59:30 UTC
if there were news, you'd be the first to hear it here
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2016-04-19 18:41:26 UTC
commit 1baf9a63bdf3283832be06bce151835922909436
Author: Stefan Sauer <ensonic@users.sf.net>
Date:   Tue Apr 19 20:39:40 2016 +0200

    mkpdf: fix exitcode
    
    Fix a regression from 12adab6b0a28aec4008c6deed247bf944b5882f2.
    
    Fixes #764543