After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764509 - network: use VPN plugin paths as specified in the .name files
network: use VPN plugin paths as specified in the .name files
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-02 18:36 UTC by Cosimo Cecchi
Modified: 2016-04-05 04:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: use VPN plugin paths as specified in the .name files (2.54 KB, patch)
2016-04-02 18:36 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2016-04-02 18:36:42 UTC 
This is a patch that was shipped from https://bugs.debian.org/743333 but never made it upstream. We ship it in Endless so I figured it would be nice to have upstream.
Comment 1 Cosimo Cecchi 2016-04-02 18:36:45 UTC 
Created attachment 325235 [details] [review]
network: use VPN plugin paths as specified in the .name files

Since LIBDIR of gnome-control-center and the VPN plugins aren't
necessarily the same, use the paths as specified by the VPN plugins and
only reconstruct the path if it is not absolute or we fail to load the
plugin.

Patch from Debian package, by Michael Biebl <biebl@debian.org>
Comment 2 Bastien Nocera 2016-04-04 16:00:20 UTC 
Review of attachment 325235 [details] [review]:

Looks good. Would have been nice if this had been upstreamed :/
Comment 3 Cosimo Cecchi 2016-04-05 04:46:59 UTC 
Pushed to master.

Attachment 325235 [details] pushed as 675ac22 - network: use VPN plugin paths as specified in the .name files