After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764386 - ephy-history-window: remove dead code
ephy-history-window: remove dead code
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
git master
Other Linux
: Normal minor
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-30 18:32 UTC by Günther Wutz
Modified: 2016-03-31 14:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Removed dead code (1.55 KB, patch)
2016-03-30 18:35 UTC, Günther Wutz 		none Details | Review
fix for compilation break (918 bytes, patch)
2016-03-31 10:48 UTC, Günther Wutz 		none Details | Review

Description Günther Wutz 2016-03-30 18:32:55 UTC 
I found dead code in ephy-history-window.c

self->window isnt referenced and gets handled at finalize-stage.

I attached a patch to get rid of that deadcode.
Comment 1 Günther Wutz 2016-03-30 18:35:44 UTC 
Created attachment 325037 [details] [review]
Removed dead code
Comment 2 Günther Wutz 2016-03-31 10:48:54 UTC 
Created attachment 325072 [details] [review]
fix for compilation break
Comment 3 Michael Catanzaro 2016-03-31 13:52:08 UTC 
Thanks. In the future, you can squash these patches together using 'git rebase -i', which is what I'm going to do when pushing them.