After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764384 - When initiating a search by typing text, the first character is lost
When initiating a search by typing text, the first character is lost
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-03-30 18:01 UTC by Dimitrios Christidis
Modified: 2016-05-31 13:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
searchbar: use gtk_entry_grab_focus_without_selecting() (884 bytes, application/mbox)
2016-03-30 18:01 UTC, Dimitrios Christidis 		  Details
searchbar: use gtk_entry_grab_focus_without_selecting() (884 bytes, patch)
2016-03-30 19:45 UTC, Dimitrios Christidis 		committed Details | Review

Description Dimitrios Christidis 2016-03-30 18:01:31 UTC 
Created attachment 325036 [details]
searchbar: use gtk_entry_grab_focus_without_selecting()

This bug was introduced with commit 8332ecb2 (bug #757278). After typing the first character, the search entry appears with its content selected. Thus, the second character will replace the first.

Using gtk_entry_grab_focus_without_selecting() fixes this bug. Furthermore, it does not effect the use of the keyboard accelerator.
Comment 1 Dimitrios Christidis 2016-03-30 19:45:41 UTC 
Created attachment 325047 [details] [review]
searchbar: use gtk_entry_grab_focus_without_selecting()

Marked attachment as a patch.
Comment 2 Cosimo Cecchi 2016-03-30 20:10:04 UTC 
Review of attachment 325047 [details] [review]:

Looks good to me, thanks!
Comment 3 Bastien Nocera 2016-05-31 13:01:35 UTC 
Committed after a few changes to the commit message.