After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764296 - Two minor fixes
Two minor fixes
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-29 00:56 UTC by Cosimo Cecchi
Modified: 2016-04-14 19:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: fix a GCC warning (1.51 KB, patch)
2016-03-29 00:56 UTC, Cosimo Cecchi 		none Details | Review
display: remove unused code (1.19 KB, patch)
2016-03-29 00:56 UTC, Cosimo Cecchi 		committed Details | Review
datetime: add -lm to libraries (1.22 KB, patch)
2016-03-29 01:00 UTC, Cosimo Cecchi 		committed Details | Review
editable-entry: use floats to avoid warning (1.55 KB, patch)
2016-03-29 03:52 UTC, Cosimo Cecchi 		committed Details | Review
network: fix a GCC warning (960 bytes, patch)
2016-04-14 19:33 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2016-03-29 00:56:34 UTC 
See patches
Comment 1 Cosimo Cecchi 2016-03-29 00:56:47 UTC 
Created attachment 324908 [details] [review]
network: fix a GCC warning
Comment 2 Cosimo Cecchi 2016-03-29 00:56:51 UTC 
Created attachment 324909 [details] [review]
display: remove unused code
Comment 3 Cosimo Cecchi 2016-03-29 01:00:57 UTC 
Created attachment 324911 [details] [review]
datetime: add -lm to libraries
Comment 4 Cosimo Cecchi 2016-03-29 03:52:04 UTC 
Created attachment 324918 [details] [review]
editable-entry: use floats to avoid warning

Or the code in g_object_set_valist() may treat the zero as a NULL, and
trigger a warning.
Comment 5 Bastien Nocera 2016-04-14 15:21:04 UTC 
Review of attachment 324908 [details] [review]:

Doesn't apply cleanly anymore.
Comment 6 Bastien Nocera 2016-04-14 15:22:52 UTC 
Review of attachment 324909 [details] [review]:

Sure.
Comment 7 Bastien Nocera 2016-04-14 15:23:32 UTC 
Review of attachment 324911 [details] [review]:

Sure.
Comment 8 Bastien Nocera 2016-04-14 15:24:05 UTC 
Review of attachment 324918 [details] [review]:

Yep.
Comment 9 Cosimo Cecchi 2016-04-14 19:33:05 UTC 
Attachment 324909 [details] pushed as cc5c94f - display: remove unused code
Attachment 324911 [details] pushed as 2fa79c3 - datetime: add -lm to libraries
Attachment 324918 [details] pushed as af6b9b6 - editable-entry: use floats to avoid warning
Comment 10 Cosimo Cecchi 2016-04-14 19:33:36 UTC 
Created attachment 326049 [details] [review]
network: fix a GCC warning
Comment 11 Bastien Nocera 2016-04-14 19:35:38 UTC 
Review of attachment 326049 [details] [review]:

Yep
Comment 12 Cosimo Cecchi 2016-04-14 19:37:20 UTC 
Thanks for the reviews!

Attachment 326049 [details] pushed as cce521d - network: fix a GCC warning