After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764293 - Add GResource helpers to PeasPluginInfo
Add GResource helpers to PeasPluginInfo
Status: RESOLVED OBSOLETE
Product: libpeas
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: libpeas-maint
libpeas-maint
Depends on:
Blocks:
 
 
Reported: 2016-03-28 22:08 UTC by Garrett Regier
Modified: 2018-05-22 12:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Preliminary patch (5.33 KB, patch)
2016-03-28 22:11 UTC, Garrett Regier 		none Details | Review

Description Garrett Regier 2016-03-28 22:08:40 UTC 
This would allow easier integration with resources and automatically handle their lifetime. GNOME-Builder would be a primary target for this API.
Comment 1 Garrett Regier 2016-03-28 22:11:43 UTC 
Created attachment 324903 [details] [review]
Preliminary patch

This is just an example of what a working patch could be, test cases are still required and actual usage would be desired for inclusion.
Comment 2 Christian Hergert 2016-03-28 22:21:22 UTC 
Review of attachment 324903 [details] [review]:

I like this. I do wonder if it would be useful to simply auto-load the module_name.gresource case.

::: libpeas/peas-plugin-info.h
@@ +85,3 @@
+                                                 const gchar          *filename,
+                                                 GError               **error);
+void         peas_plugin_info_load_resource     (const PeasPluginInfo *info,

whitespace
Comment 3 Garrett Regier 2017-03-25 04:40:52 UTC 
Autoloading will break plugins/applications that are already loading the same .gresource file (i.e. Builder).

It might be a better idea to add a key to the .plugin file which would cause them to automatically be loaded or Builder could just call peas_plugin_info_load_resource() manually for every plugin.
Comment 4 GNOME Infrastructure Team 2018-05-22 12:15:12 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/libpeas/issues/20.