After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764280 - [PATCH] opening calendar settings twice results in empty window
[PATCH] opening calendar settings twice results in empty window
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: General
3.20.x
Other Linux
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-28 11:41 UTC by Marinus Schraal
Modified: 2017-04-17 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
source-dialog: Don't destroy on close. (1.40 KB, patch)
2016-03-28 11:51 UTC, Marinus Schraal 		none Details | Review
source-dialog: Don't destroy on close. (1.04 KB, patch)
2016-03-28 17:07 UTC, Marinus Schraal 		none Details | Review
window.ui: Don't destroy GcalSourceDialog on close. (1.05 KB, patch)
2016-03-28 18:49 UTC, Marinus Schraal 		committed Details | Review

Description Marinus Schraal 2016-03-28 11:41:58 UTC 
The change to not use gtk_dialog_run() anymore for the source-dialog results in it being destroyed after first use (gtk_dialog_run stops propagating the delete-event). Either revert the commit or see proposed patch for solution.
Comment 1 Marinus Schraal 2016-03-28 11:51:53 UTC 
Created attachment 324868 [details] [review]
source-dialog: Don't destroy on close.

Since the change in d5cd6c7fc9fc0dc6e7d22927af983dfc908fe50b , closing
the source dialog actually destroyed it and could not be used again.

The previously used gtk_dialog_run() handled the delete event in a
non-destructive way, implement a similar approach in
gcal-source-dialog instead.
Comment 2 Marinus Schraal 2016-03-28 17:07:34 UTC 
Created attachment 324881 [details] [review]
source-dialog: Don't destroy on close.

Since the change in d5cd6c7fc9fc0dc6e7d22927af983dfc908fe50b, closing
the source dialog  actually destroyed it and could not be used again.

Use gtk_widget_hide_on_delete to handle the delete-event.
Comment 3 Marinus Schraal 2016-03-28 18:49:25 UTC 
Created attachment 324892 [details] [review]
window.ui: Don't destroy GcalSourceDialog on close.

Since the change in d5cd6c7fc9fc0dc6e7d22927af983dfc908fe50b closing
the source dialog actually destroyed it and could not be used again.

Use gtk_widget_hide_on_delete to handle the delete-event.
Comment 4 Georges Basile Stavracas Neto 2016-04-07 21:38:45 UTC 
Attachment 324892 [details] pushed as 12ad480 and 7baaf10 - window.ui: Don't destroy GcalSourceDialog on close.