After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764237 - Set G_LOG_DOMAIN to OSTree
Set G_LOG_DOMAIN to OSTree
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-03-26 15:43 UTC by Dan Nicholson
Modified: 2016-03-26 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Set G_LOG_DOMAIN to OSTree (1.04 KB, patch)
2016-03-26 15:43 UTC, Dan Nicholson 		accepted-commit_now Details | Review
main: Set log handler for OSTree domain (1.46 KB, patch)
2016-03-26 15:43 UTC, Dan Nicholson 		accepted-commit_now Details | Review

Description Dan Nicholson 2016-03-26 15:43:28 UTC 
This will allow OSTree applications to filter messages appropriately
without having to specify the NULL domain.
Comment 1 Dan Nicholson 2016-03-26 15:43:31 UTC 
Created attachment 324797 [details] [review]
build: Set G_LOG_DOMAIN to OSTree

This will allow ostree programs to filter log messages specifically for
OSTree instead of using the NULL domain for ostree debugging.
Comment 2 Dan Nicholson 2016-03-26 15:43:34 UTC 
Created attachment 324798 [details] [review]
main: Set log handler for OSTree domain

Now that OSTree is used as G_LOG_DOMAIN, set the main handler to match
so the appropriate messages are filtered. It would probably be more
appropriate to spell out "OSTree" in the code, but since G_LOG_DOMAIN is
being defined globally in the project, might as well reuse it here.
Comment 3 Colin Walters 2016-03-26 18:21:51 UTC 
Review of attachment 324797 [details] [review]:

LGTM
Comment 4 Colin Walters 2016-03-26 18:22:34 UTC 
Review of attachment 324798 [details] [review]:

I'd prefer squashing this with the previous commit.
Comment 5 Colin Walters 2016-03-26 18:25:24 UTC 
https://github.com/ostreedev/ostree/pull/225

Nevermind re squashing, this does make sense separate.
Comment 6 Colin Walters 2016-03-26 18:27:01 UTC 
Thanks for the patches!