After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764220 - media-keys: add Super+F1 as a hardcoded shortcut for launching Help
media-keys: add Super+F1 as a hardcoded shortcut for launching Help
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: media-keys
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2016-03-25 23:30 UTC by Cosimo Cecchi
Modified: 2018-01-24 13:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
media-keys: add Super+F1 as a hardcoded shortcut for launching Help (1.25 KB, patch)
2016-03-25 23:30 UTC, Cosimo Cecchi
none Details | Review
media-keys: add Super+F1 as a hardcoded shortcut for launching Help (1.28 KB, patch)
2016-04-05 15:32 UTC, Cosimo Cecchi
committed Details | Review

Description Cosimo Cecchi 2016-03-25 23:30:11 UTC
See attached patch.
Comment 1 Cosimo Cecchi 2016-03-25 23:30:13 UTC
Created attachment 324777 [details] [review]
media-keys: add Super+F1 as a hardcoded shortcut for launching Help

This is what Windows hardcodes, and some laptops have keyboards with
"help" physical keys that send Super+F1 when pressed.
Comment 2 Bastien Nocera 2016-04-05 12:48:24 UTC
Review of attachment 324777 [details] [review]:

> and some laptops

Can you list at least one of the laptops that does this?

::: plugins/media-keys/shortcuts-list.h
@@ +65,3 @@
         { SCREENSAVER_KEY, NULL, N_("Lock Screen"), "XF86ScreenSaver", SCREENSAVER_MODE },
         { HELP_KEY, "help", NULL, NULL, GSD_ACTION_MODE_LAUNCHER },
+        { HELP_KEY, NULL, NULL, "<Super>F1", GSD_ACTION_MODE_LAUNCHER },

You'll need to give it a name as well. This will be used in the keyboard shortcuts panel to warn about hard-coded shortcuts.
Comment 3 Cosimo Cecchi 2016-04-05 15:32:30 UTC
Created attachment 325439 [details] [review]
media-keys: add Super+F1 as a hardcoded shortcut for launching Help

This is what Windows hardcodes, and some laptops (such as the HP Stream
11") have keyboards with "help" physical keys that send Super+F1 when
pressed.
Comment 4 Bastien Nocera 2016-04-05 16:44:55 UTC
Review of attachment 325439 [details] [review]:

Looks good, please branch for gnome-3-20 before committing.
Comment 5 Cosimo Cecchi 2016-04-05 17:12:39 UTC
Attachment 325439 [details] pushed as 147c0b2 - media-keys: add Super+F1 as a hardcoded shortcut for launching Help
Comment 6 Tino Calancha 2016-09-08 07:07:47 UTC
(In reply to Cosimo Cecchi from comment #5)
> Attachment 325439 [details] pushed as 147c0b2 - media-keys: add Super+F1 as
> a hardcoded shortcut for launching Help

Hi,
i bind "<Super>F1" to one Emacs command.  After this commit "<super>F1">
launchs the gnome help breaking my usual binding (Bug#771014).
In the shortcuts panel, 'Launch help browser' is disabled so there is no
obvious way to disable it.
Could you consider set this binding as a default value in the shortcuts
panel instead of setting it here? Then, users are able to disable/change it.

Thank you.
My OS is Debian Strech.
Comment 7 Bastien Nocera 2018-01-24 13:56:42 UTC
*** Bug 789334 has been marked as a duplicate of this bug. ***