GNOME Bugzilla – Bug 76420
GNOME Archive Generator needs a 'Stop' button
Last modified: 2004-12-22 21:47:04 UTC
- File menu: All items need mnemonics, Exit should be "Quit", Quit missing stock icon - Edit menu: Remove needs mnemonic - Suggest "Clear" should be "Remove All" (for consistency with "Remove" item) - Help menu: About should be "About Archive Generator" - "Archive" button should have a mnemonic - Need progress indicator during archive creation + ability to Cancel - No indication in application of what format archives are generated in, or how to unarchive them again (since the app doesn't seem to support unarchiving) - First item in list should automatically get focus when you tab into it and there is no current selection-- currently focus indicator just vanishes, which is an accessibility issue
Calumn: a quick comment. Many of the menu items are stock libgnomeui items. So the File/exit and Help/About... are generated in libgnomeui using the GNOMEUIINFO_MENU_EXIT_ITEM and GNOMEUIINFO_MENU_ABOUT_ITEM structures. I suggest filing a bug in libgnomeui pertaining to those items so that every app will be complient in those issues. Also, for me the archive button has an icon. How should I assign a mnemonic for that?
Apologies on the missing stock icon report-- stock icons on menus were broken in the environment I tested, but are now working, but I forgot to remove that part before filing the bug. Please ignore. There's still no icon on my "Archive" button, though (Solaris 8, community beta 2 build)-- are you saying there should be? The mnemonic for this button should probably just be _A, as that wouldn't clash with the mnemonics for any of the menu titles.
adding "doc" keyword. I'm not sure what the status of these docs is, but we need to track it down and coordinate any of these changes made with the documentation.
Calumn, the code searches for the archive icon, and then makes the button display the icon. If the icon is not found then the button displays the text you have. I'm guessing probably the best thing here is to always display text instead of an icon.
Aha... that would explain a lot :) Where does it look for the icon? It sounds like it could be a bug against our Solaris builds, which doesn't always put things in the places you might find them on Linux... As for always displaying text-- yes, that would be a good option for accessibility reasons anyway. Even better might be to read the icon/text/both setting from the "Menus & Toolbars" control panel, and decide what to display according to that. (Assuming there's no equivalent to the 1.4 'display icons on dialog buttons' setting any more-- if there is, maybe that would be the one to use).
Actually, since it's already a stock item, it's probably more sensible just to go with "Help->About" rather than trying to hack it to read "Help->About <appname>" for 2.0.
Okay, I've changed libgnomeui so it will do 'Quit' instead of 'Exit'. Is this worth pursuing on the Help front? GNOME 2.0 in any case unless we punt otherwise.
Okay, I'm working on this and about 80% finished.
1st 5 items are done. The other 3 are reasonably straightforward. Adding easy-fix. The progress indicator is probably an enhancement - so I think this could probably be punted.
Created attachment 8146 [details] [review] patch for last item
Hum, just applied this patch and it seems to be broken in that the first item will always get focus...which makes keyboard navigation through the icon view broken.
Reassigning back for people wanting to work on this.
The first icon/item gets focused only when there is no previous selection exists. Is it not the expected behaviour ?
Well, when I tried the patch, the first item indeed got focused, but then you were not able to tab between the other entries [when you added more files] as it was always grabbed on the first item.
Guys: has anyone checked to see if the gnome-icon-selector widget is the problem? Wouldn't it be smarter to fix it in libgnomeui? I don't think archive-generator is doing anything special with the widget (though I haven't really looked at the code yet).
To summarize what is left in this bug * the focus problem * the progress indicator [we just need to add a hbox and dump the existing status bar along with a progress bar] - hum, perhaps we should be using gnome-app-bar now :/
Okay, I'm pretty sure this is a libgnomeui bug as kevin said.
Okay, I've commit code to make it into an gnome-appbar. I haven't had time to figure out how to get the appbar pulsating yet for the progress stuff...it kinda looks assy right now without the latest libgnome[ui] that reverses the order of the status bar.
Okay, I've hooked up the progress bar...because I'm getting weird errors from /bin/sh -c :( I think it works, but the file selection dialog still might not disappear immediately when you archive large things - need to check this sometime ;) Probably still needs a 'Stop button' - ie. Create Archive turns into a Stop button.
Not sure whether a Stop or a Cancel button would be better here; Stop would only be useful if you could see which files had already been placed in the archive (or you could be shown immediately after you pressed Stop, with an option to Resume). Cancel would just delete the incomplete archive file and you'd have to start again. Definitely needs one or the other though, not to do so is non-HIG-compliant :)
Okay, removing keynav and accessibility - they've been fixed in libgnomeui.
Changing keyword to 2.0.2, still welcome to work on it, of course, but it won't stop 2.0.1.
meatgrinder is going away for 2.2 - unless it doesn't make the proposed modules list. we'll reopen if it doesn't.