After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764198 - _validate_next_track should skip https urls
_validate_next_track should skip https urls
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.20.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2016-03-25 14:31 UTC by Nikita Uvarov
Modified: 2016-04-21 10:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch that fixes url validation logic (651 bytes, patch)
2016-03-25 14:31 UTC, Nikita Uvarov 		committed Details | Review

Description Nikita Uvarov 2016-03-25 14:31:45 UTC 
Created attachment 324759 [details] [review]
Patch that fixes url validation logic

Function _validate_next_track in Player class should skip remote tracks with https schema as well, now only http one is checked.

In attachments I added patch that fixes this bug.
In addition I removed unnecessary assignment to status variable.
Comment 1 Felipe Borges 2016-04-21 10:47:54 UTC 
Review of attachment 324759 [details] [review]:

makes sense.
Comment 2 Felipe Borges 2016-04-21 10:50:12 UTC 
pushed as 70dc7ca - player: _validate_next_track should skip https urls

Thanks for your patch!