After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764162 - avvid{dec,enc}: remove dead gobject macros
avvid{dec,enc}: remove dead gobject macros
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
unspecified
Other All
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-24 17:38 UTC by Víctor Manuel Jáquez Leal
Modified: 2016-03-25 12:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
avvid{dec,enc}: remove dead gobject macros (2.10 KB, patch)
2016-03-24 17:38 UTC, Víctor Manuel Jáquez Leal
committed Details | Review

Description Víctor Manuel Jáquez Leal 2016-03-24 17:38:24 UTC
See patch description
Comment 1 Víctor Manuel Jáquez Leal 2016-03-24 17:38:28 UTC
Created attachment 324695 [details] [review]
avvid{dec,enc}: remove dead gobject macros

The GObject macros either for GstFFMpegVidDec and GstFFMpegVidEnc can
break the compilation because they are not GTypes, since each av video
elements are registered in runtime.
Comment 2 Sebastian Dröge (slomo) 2016-03-24 18:28:45 UTC
Comment on attachment 324695 [details] [review]
avvid{dec,enc}: remove dead gobject macros

Makes sense. I guess for clarity I would nowadays make those the base class, and register all the codecs/demuxers/muxers as subclasses of that base class.
Comment 3 Víctor Manuel Jáquez Leal 2016-03-25 11:57:57 UTC
Attachment 324695 [details] pushed as 1af733a - avvid{dec,enc}: remove dead gobject macros