After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764143 - Artist preferred over AlbumArtist when adding AlbumArtist data
Artist preferred over AlbumArtist when adding AlbumArtist data
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: Extractor
git master
Other Linux
: Normal normal
: ---
Assigned To: tracker-extractor
tracker-extractor
Depends on:
Blocks:
 
 
Reported: 2016-03-24 13:13 UTC by Gaurav Narula
Modified: 2016-05-07 17:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Prefer TPE2 tag for AlbumArtist (3.72 KB, patch)
2016-03-24 13:26 UTC, Gaurav Narula 		none Details | Review
Prefer TPE2 tag for AlbumArtist (3.39 KB, patch)
2016-03-24 18:41 UTC, Gaurav Narula 		committed Details | Review

Description Gaurav Narula 2016-03-24 13:13:54 UTC 
MP3 extracter currently gives priority to artist tag (TPE1) over albumArtist tag (TPE2) when adding albumArtist information.

Example:

ID3Info:
https://paste.gnome.org/pzvoffbxx

./tracker-extract -f <filename>
https://paste.gnome.org/plthlr5bx

Relevant lines are 85 and 86 in the second link where albumArtist is set to Mark Ronson instead of Various Artists.
Comment 1 Gaurav Narula 2016-03-24 13:26:41 UTC 
Created attachment 324676 [details] [review]
Prefer TPE2 tag for AlbumArtist
Comment 2 Carlos Garnacho 2016-03-24 13:40:50 UTC 
Review of attachment 324676 [details] [review]:

Looks mostly good! thanks for the patch. Just two minor nits, can be pushed after fixing.

::: src/tracker-extract/tracker-extract-mp3.c
@@ +2372,3 @@
 	                                       md.id3v1.artist);
 
+    md.album_artist = tracker_coalesce_strip (3, md.id3v24.performer2,

Indenting got wrong here :). Keep in mind the weird tracker code style, tabs for code flow related indenting, spaces to add padding in eg. multiline declarations, something like:

<tab>md.album_artist = tracker_coalesce_strip (...,
<tab>                                          ...);

here.

@@ +2418,3 @@
 	                                        md.id3v22.encoded_by);
 
+

and this extra space might go :)
Comment 3 Gaurav Narula 2016-03-24 18:41:16 UTC 
Created attachment 324716 [details] [review]
Prefer TPE2 tag for AlbumArtist

Thanks for your review! Fixed the indentation issues. Should be good to commit now :)
Comment 4 Carlos Garnacho 2016-05-07 17:10:30 UTC 
Thanks very much for the patch! And sorry it took long... it's now in git.